Remove the -s flag to rez-pip because "pip search" is decommissioned #1105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1104 .
As the title says, remove the
-sflag torez-pipbecausepip searchfunctionality that was provided by PyPI has been decommissioned, see https://status.python.org/incidents/grk0k7sz6zkp.Recent pip versions prints a nice error message, but studios using an older version just gets an unhandled error from pip.
So the safe thing to do is to remove the flag. I could keep the flag and simply print an error, but in my opinion, just getting rid of the flag should be enough... In any case, let me know and I can re-introduce the flag and print a user friendly error message.