Fix package_cache_async
missing from ResolvedContext
dict round-trip
#1810
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up fix to #1679
The new
package_cache_async
attribute on theResolvedContext
class was not being round-tripped through the context serialization process. This leads to the following error after spawning a shell (when therezolve context
command runs):I will note that it seems a bit strange for
ResolvedContext.from_dict
to callcontext._update_package_cache()
after creating a new instance, but I assume there are some historical reasons for this. However, given this pattern, ifpackage_cache_async
is set toFalse
,from_dict
could potentially block for a very long time.CC @isohedronpipeline for visibility.