Remove duplicate JWT related code in favor of RIG.JWT
#244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinbader
force-pushed
the
refactor-jwt-code
branch
2 times, most recently
from
f8d7c8b to
bcd6491
Compare
kevinbader
force-pushed
the
refactor-jwt-code
branch
from
bcd6491 to
239f4a2
Compare
mmacai
approved these changes
Aug 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When encoding or decoding JWTs somewhere in the code, you have multiple options - depending on whether it's test or production code, or in which OTP app you're in. This PR favors the implementation in
RIG.JWTand removes all others.What to look out for
Dear reviewer, I want you to