Skip to content

Refine session related code: rename it, add tests, fix bugs, update docs #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 6, 2019
Merged

Refine session related code: rename it, add tests, fix bugs, update docs #260

merged 4 commits into from
Sep 6, 2019

Conversation

kevinbader
Copy link
Contributor

Description

  • Got rid of RigAuth and moved the Session module as well as the authorization-check modules under the RIG namespace.
  • Fix: A connection is now associated to its session right after the connection is established, given the request carries a JWT in its authorization header.
  • Added unit tests for the session module.

What to look out for

Dear reviewer, I want you to

  • gain knowledge - I think it's important for you to know about the change.
  • help to find bugs.

Have fun!

Refine session related code: rename it, add tests, fix bugs, update docs
c696d79 
A connection is now associated to its session right after the connection
is established, given the request carries a JWT in its authorization
header. Previously, this was only done by the subscriptions endpoint,
which could cause a connection to remain active even after blacklisting
its authorization token.
@kevinbader kevinbader changed the title WIP: Refine session related code: rename it, add tests, fix bugs, update docs Refine session related code: rename it, add tests, fix bugs, update docs Sep 4, 2019
@kevinbader kevinbader requested a review from mmacai September 4, 2019 20:35
@kevinbader kevinbader added this to the 2.3.0 milestone Sep 4, 2019
mmacai
mmacai reviewed Sep 5, 2019
View reviewed changes
@mmacai
Copy link
Collaborator

mmacai commented Sep 5, 2019

Running smoke tests and getting logs below, can you confirm?

╓─────[ Running tests, plaintext Kafka connection ]─────╖

Starting zookeeper ... done
Starting rest-api  ... done
Starting kafka     ... done
08:09:37.074 module=Rig.Config [error] Could not resolve HTTPS_CERTFILE: "cert/selfsigned.pem"
08:09:37.092 module=Rig.Config [error] Could not resolve HTTPS_KEYFILE: "cert/selfsigned_key.des3.pem"

@kevinbader kevinbader merged commit 9b9bd23 into master Sep 6, 2019
@kevinbader kevinbader deleted the refine-session branch September 6, 2019 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmacai mmacai mmacai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@kevinbader @mmacai