Add blacklist i9n test and fix some stuff along the way #261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added: - When terminating an SSE connection after its associated session has been blacklisted, RIG now sends out a `rig.session_killed` event before closing the socket. Changed: - When a session has been added to the session blacklist successfully, the endpoint now uses the correct HTTP status code "201 Created" instead of "200 Ok". - When using the API to blacklist a session, the `validityInSeconds` should now be passed as an integer value (see `Deprecated` below). Deprecated: - When using the API to blacklist a session, passing the `validityInSeconds` field as a string is deprecated (but supported until the 3.0 release). Please use an integer instead. Removed: - Removed the `JWT_BLACKLIST_DEFAULT_EXPIRY_HOURS` environment variable ([deprecated since 2.0.0-beta.2]). Security: - A connection is now associated to its session right after the connection is established, given the request carries a JWT in its authorization header. Previously, this was only done by the subscriptions endpoint, which could cause a connection to remain active even after blacklisting its authorization token. [deprecated since 2.0.0-beta.2]: f974533
kevinbader
changed the title
kevinbader
force-pushed
the
blacklist-i9n-test
branch
from
8575fdc to
bfd4478
Compare
kevinbader
changed the title
mmacai
reviewed
Sep 17, 2019
mmacai
approved these changes
Sep 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added:
been blacklisted, RIG now sends out a
rig.session_killedevent beforeclosing the socket.
/v2/session-blacklist, which introduces the following breaking changes:validityInSecondsshould now be passed as an integer value (using a string still works though).Removed:
JWT_BLACKLIST_DEFAULT_EXPIRY_HOURSenvironment variable(deprecated since 2.0.0-beta.2).
Security:
connection is established, given the request carries a JWT in its
authorization header. Previously, this was only done by the
subscriptions endpoint, which could cause a connection to remain active
even after blacklisting its authorization token.
On a side note, I've also improved the logging a bit: in
debuglevel, there haven't been any logs in case theon_errorcallback was invoked in theConnectionInitmodule; now RIG will tell us in case something went wrong, and even output all the outgoing messages, at least for SSE.What to look out for
Dear reviewer, I want you to
I know that we still don't have anything on the blacklist feature on the website, but let's resolve this in a follow-up PR.