229 - Reverse proxy - new Kafka/Kinesis config #263
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #229
What to look out for
@kevinbader - want to go out firstly with documentation and thoughts and then start with implementation. Please check notes below.examples/kinesis-localstack/README.md
Notes:
topic
andschema
fields - perhaps they should be namedrequest_topic
andrequest_schema
to make it more clear, that they are used just for publishing, not consumingtarget_partition
would be optional and if not set -- randomizedtopic
andschema
fields in the config, if not present -> check env varstopic
field mandatoryExtra notes:
handle_http_request
function) since the deprecated way will be removed eventually and therefore extracting common logic didn't make sense to me