Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder Recruitment tags in order of appearance #159

Merged
merged 7 commits into from
Aug 12, 2023
Merged

Conversation

az3
Copy link
Contributor

@az3 az3 commented Dec 18, 2022

In the recruitment, the tags appear in a specific order. For example Survival tag always comes before AoE. To simulate this behaviour, tags are updated.

With this commit, only the ordering is changed.

@az3 az3 changed the title Reorder tags in order of appearance. Reorder Recruitment tags in order of appearance Dec 26, 2022
@az3
Copy link
Contributor Author

az3 commented Aug 1, 2023

@Aceship Hello, do you have any plans to check this request?

The outcome is identical, only the ordering is updated with this change. So it is easier to track the tags.

For example for this recruitment (in game menu) options;
image

Web site will display tags in the same order as they appear in game;
image

Thanks for your concern.

@Aceship
Copy link
Owner

Aceship commented Aug 4, 2023

The outcome is identical, only the ordering is updated with this change. So it is easier to track the tags.

ngl i havent been checking the recruit stuff

does it also have the same order on other language ?

i'll check the chinese one for now

@Aceship
Copy link
Owner

Aceship commented Aug 4, 2023

seems like its okay on chinese client, still dont know about the other language tho

@az3
Copy link
Contributor Author

az3 commented Aug 7, 2023

does it also have the same order on other language ?

I used "Ptilop.sys" from Android, and it also shows them in the same order. It is safe to assume they will be same in TW & JP, too.

@Aceship Aceship merged commit efbb6d9 into Aceship:master Aug 12, 2023
@Aceship
Copy link
Owner

Aceship commented Aug 12, 2023

I used "Ptilop.sys" from Android, and it also shows them in the same order. It is safe to assume they will be same in TW & JP, too.

ah okay, i guess its fine, thanks for the pr 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants