BUG: `ngfDrop` directive doesn't work with IE11

[anield]

Drop a file on ngfDrop zone in IE11 and it will open in browser (default IE file drop action).

Can reproduce using demo site:
https://ackerapple.github.io/angular-file/

The original unforked ng2FileDrop directive still works fine with IE11 here:
https://valor-software.com/ng2-file-upload/

I did a small amount of debugging - it appears the drop event is handled by ngfDrop.onDrop() but files = [] here:

let files = this.eventToFiles(event)

if(!files.length)return

[AckerApple]

Hmmmmmmm. Almost enough details but I can’t see what the error is. Can you try again or elaborate on what you think the problem is.

[AckerApple]

I’m guessing theirs no error but just no files get dropped?

[anield]

yeah no error - presumably the dropped files are not being unwrapped correctly inside eventToFiles(). I'll see if I can debug some more.

[figuerres]

i have not had time to check but one big thing that may be in issue is to make sure that you add the IE 11 polyfills in a new project, ie 11 does not have some script stuff that chrome has.
the other thing is some css things do not work on ie 11 that work on chrome and need work arounds.
that is the two main areas that tend to be the problem.

[AckerApple]

Please wait... typing. @figuerres, you're a genius

[figuerres]

sometimes yes, other times not so much.

[AckerApple]

I'm in the middle of something so I can't respond like I would like to. It is the polyfills. My example page doesn't have the polyfills.

I need to add the polyfills back in

[AckerApple]

Well actually now that I got a second to look, the polyfills seem like they should be in the example, as seen in this line of code for the demo page:
https://github.com/AckerApple/angular-file/blob/development/demo/src/index.ts#L1

It still could be a pollyfills thing though, just saying code suggests it should be there. ALSO, if it was a polyfill issue we'd have an actual error.

Hmmmmmmmmmmmm, leaning away from polyfill now

[anield]

I tried adding missing polyfills locally (we had most of them already) and it didn't seem to make a difference.

[AckerApple]

I only have a copy of IE11 at the office. I won’t be there till Monday and even then I gotta get someone else to get the machine turned on.

I used to use an online IE emulator. If you know how a Mac guy could easily test IE11, let me know

[figuerres]

Actually Microsoft does have a way to help
They publish free vm images of several versions of ie for multiple vm systems
https://developer.microsoft.com/en-us/microsoft-edge/tools/vms/
Might help.

[AckerApple]

Acknowledged. Good stuff. Will check it out tomorrow as today, Sunday, is filled

[figuerres]

Yeah, this weekend I have been doing neglected cleaning and water change on my 150 gallon saltwater aquarium, what a pain....

[AckerApple]

The issue, is IE11 does not indicate the amount of files being dragged nor the types of files being dragged. It appears all other browsers, on drag over, the number of files and types are revealed.

IE11, during drag, files.length always is present and equals zero

So the fix I have NOT yet posted removes the files.length check as seen here:
https://github.com/AckerApple/angular-file/blob/development/src/file-upload/ngfDrop.directive.ts#L38

Fix will be posted within an hour

[AckerApple]

Fixed in version 0.3.3 . Examples page updated . Please test and close issue or report more.