Feature/cur 4002 publish activity to canvas #1288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iveLearningStudio-API into feature/CUR-4002-publish-activity-to-canvas
…iveLearningStudio-API into feature/CUR-4002-publish-activity-to-canvas
…iveLearningStudio-API into feature/CUR-4002-publish-activity-to-canvas
…iveLearningStudio-API into feature/CUR-4002-publish-activity-to-canvas
aqeel-tkxel
suggested changes
Sep 22, 2022
app/CurrikiGo/Canvas/Activity.php
Outdated
Comment on lines
50
to
54
| public function send(ActivityModel $activity, $data) | ||
| { | ||
|
|
||
| } | ||
| } |
There was a problem hiding this comment.
Are we using this class for anything? If not, it could be deleted.
app/CurrikiGo/Canvas/Commands/CreateAssignmentGroupsCommand.php
Outdated
Show resolved
Hide resolved
Comment on lines
+64
to
+70
| try { | ||
| $response = $this->httpClient->request('GET', $this->apiURL . '/courses/' . $this->courseId . '/' . $this->endpoint . '?per_page=1000', [ | ||
| 'headers' => ['Authorization' => "Bearer {$this->accessToken}"] | ||
| ])->getBody()->getContents(); | ||
| $response = json_decode($response); | ||
| } catch (Exception $ex) { | ||
| } |
There was a problem hiding this comment.
Pulling in too many records here?
…iveLearningStudio-API into feature/CUR-4002-publish-activity-to-canvas
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Publishing activity to canvas, existing feature of publishing project to canvas is also modified, following the logical flow of GCR