CUR-4163-add background job for publishing #1325
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * "message": "The given data was invalid.", | ||
| * "errors": { | ||
| * "aSyncUrl": [ | ||
| * "The a sync url field is required." |
There was a problem hiding this comment.
Need to removed "aSyncUrl" errors.
| * @param $aSyncUrl string | ||
| */ | ||
| public function createMSTeamAssignment($token, $classId, $activity); | ||
| public function createMSTeamAssignment($token, $classId, $project, $aSyncUrl); |
| public function createMsTeamClass($token, $data); | ||
|
|
||
| /** | ||
| /** |
| */ | ||
| private function getUserDetails($token) | ||
| { | ||
| $apiURL = $this->landingUrl . '/me'; |
There was a problem hiding this comment.
Indentation/formatting issue.
| public function createMSTeamAssignment($token, $classId, $project, $aSyncUrl) | ||
| { | ||
| \Log::info('in createMSTeamAssignment'); | ||
| if(!empty($aSyncUrl)) { |
There was a problem hiding this comment.
Code optimization required.
| private function checkClassAsyncStatus($aSyncUrl, $token) | ||
| { | ||
| \Log::info('in checkClassAsyncStatus'); | ||
| if($aSyncUrl !== Null) { |
There was a problem hiding this comment.
Add space after "if" and before "else" in "} else"
fahad-curriki
approved these changes
Sep 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature/cur 4163 add abackground job publishing projectms team