Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix target PR not being found due to paging search results #2482

Merged
merged 1 commit into from
Apr 10, 2023
Merged

Fix target PR not being found due to paging search results #2482

merged 1 commit into from
Apr 10, 2023

Conversation

Naatan
Copy link
Member

@Naatan Naatan commented Apr 10, 2023 •
edited by github-actions bot
Loading

BugDX-1726 target-version-pr fails due to paging

@Naatan Naatan requested a review from mitchell-as April 10, 2023 16:36
@github-actions github-actions bot changed the base branch from master to version/0-39-0-RC1 April 10, 2023 16:37
mitchell-as
mitchell-as requested changes Apr 10, 2023
View reviewed changes
Copy link
Contributor

@mitchell-as mitchell-as left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GA changed the target, resulting in a diff impossible to review. This wasn't intentional, was it?

@Naatan
Copy link
Member Author

Naatan commented Apr 10, 2023

@mitchell-as fixed

@Naatan Naatan requested a review from mitchell-as April 10, 2023 17:00
@Naatan Naatan merged commit 31c2543 into version/0-39-0-RC1 Apr 10, 2023
@Naatan Naatan deleted the DX-1726 branch April 10, 2023 17:04
as-builds added a commit that referenced this pull request Apr 10, 2023
@as-builds
Merge branch version/0-39-0-RC1 to adopt changes from PR #2482
da4d537
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitchell-as mitchell-as mitchell-as approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Naatan @mitchell-as