Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include original webclient ID in auth and signup URLs. #3083

Closed
wants to merge 212 commits into from
Closed

Include original webclient ID in auth and signup URLs. #3083

wants to merge 212 commits into from

Conversation

mitchell-as
Copy link
Contributor

@mitchell-as mitchell-as commented Feb 5, 2024 •
edited by github-actions bot
Loading

StoryDX-2529 Pass webclient_id to signup and sign-in pages

The login URL will look like this:

https://platform.activestate.com/authorize/device?user-code=<uuid>&webclient_id=<id>

and the signup URL will look like this:

https://platform.activestate.com/create-account?nextRoute=%2Fauthorize%2Fdevice%3Fuser-code%3D<uuid>&webclient_id=<id>

Note that webclient_id for the signup page is part of the request to create-account, not a follow up query to the nextRoute page.

mitchell-as and others added 30 commits November 29, 2023 10:05
@mitchell-as
Re-enable localcommits and buildscripts.
4aeec49
@Naatan
update version.txt to v0.44.0-RC1
c33086f
@mitchell-as
Fixed formatted message value.
4b28005 
Use the return value instead of the function value.
@mitchell-as
Uninstalling in an activated state is an input error.
72c7ebf 
Do not log it to Rollbar.
@mitchell-as
Merge pull request #2987 from ActiveState/mitchell/dx-2421
d9750de 
Uninstalling in an activated state is an input error.
@mitchell-as
Merge pull request #2988 from ActiveState/mitchell/dx-2415
d6c5306 
Fixed formatted message value.
@mitchell-as
Propagate extra test session environment variables.
e73ba2a
@mitchell-as
The CI environment sandbox needs to pass through ACTIVESTATE_CI.
5d305cd 
Otherwise analytics will be skewed.
@mitchell-as
Merge pull request #2989 from ActiveState/mitchell/dx-2427
c4b2ad0 
Propagate extra test session environment variables.
@mitchell-as
Merge pull request #2991 from ActiveState/mitchell/dx-2426
a8acdaf 
The CI environment sandbox needs to pass through `ACTIVESTATE_CI`.
@MDrakos
Fix failing integration tests
98935d4
@MDrakos
Add env var to disable events
96038f6
@MDrakos
Revert "Fix failing integration tests"
e70c139 
This reverts commit 98935d4.
@MDrakos
Enable runtime for tests that use it
297e246
@MDrakos @Naatan
Update test/integration/run_int_test.go
b5bd2a1 
Co-authored-by: Nathan Rijksen <nathanr@activestate.com>
@MDrakos
Merge pull request #2993 from ActiveState/DX-2432
2daddca 
Fix failing integration tests
@mitchell-as
Attempting to checkout to a directory without permission should resul…
c9c5cd6 
…t in a friendly error message.
@mitchell-as
Merge pull request #2997 from ActiveState/mitchell/dx-2413
bb5c00f 
Attempting to checkout to a directory without permission should result in a friendly error message.
@mitchell-as
Do not report to Rollbar permission errors when creating shell comple…
5700b7a 
…tions.

Cobra is attempting to do it, and we have no control over how it does so.
@mitchell-as
Consider 'sh' to be a known shell, but unsupported.
4691f58 
This is so we don't log it to Rollbar.
@mitchell-as
Localize an error when fetching a platform recipe.
55c3fb6
@mitchell-as
Merge pull request #2998 from ActiveState/mitchell/dx-2414
27c22a3 
Do not report to Rollbar permission errors when creating shell completions.
@mitchell-as
Do not attempt to reset executors for a default project that no longe…
9698b87 
…r exists.
@mitchell-as
Added period to emphasize a complete sentence.
2051813 
A quick read may lead to thinking the sentence is incomplete and missing data.
@mitchell-as
Merge pull request #3002 from ActiveState/mitchell/dx-2405
50c4f72 
Added period to emphasize a complete sentence.
@mitchell-as
Merge pull request #3001 from ActiveState/mitchell/dx-2420
0859b59 
Do not attempt to reset executors for a default project that no longer exists.
@mitchell-as
Merge pull request #3000 from ActiveState/mitchell/dx-2418
b722c2e 
Localize an error when fetching a platform recipe.
@mitchell-as
Merge pull request #2999 from ActiveState/mitchell/dx-2417
eb39e1a 
Consider 'sh' to be a known shell, but unsupported.
@MDrakos
Revert "Merge pull request #2993 from ActiveState/DX-2432"
c485f4d 
This reverts commit 2daddca, reversing
changes made to a8acdaf.
@MDrakos
Revert "Merge pull request #2991 from ActiveState/mitchell/dx-2426"
e684730 
This reverts commit a8acdaf, reversing
changes made to c4b2ad0.
Naatan and others added 24 commits January 31, 2024 08:52
@Naatan
Drop comments
bf7cd23
@as-builds
Merge branch version/0-43-0-RC2 to adopt changes from PR #3067
b452f21
@Naatan
Merge branch 'version/0-44-0-RC1' into DX-2423
4debc61 
# Conflicts:
#	pkg/platform/runtime/buildplan/buildplan.go
@Naatan
Merge pull request #3066 from ActiveState/DX-2506
6be317a 
Implement new migration flow for local orders
@Naatan
Merge pull request #3062 from ActiveState/DX-2423
a72f4c0 
Implement 'state builds'
@as-builds
Merge branch version/0-43-0-RC2 to adopt changes from PR #3068
2b62cf1
@as-builds
Merge branch version/0-43-0-RC2 to adopt changes from PR #3065
b4f6ae2
@mitchell-as
Validate UUID for namespace arguments.
9cd9da5 
Invalid UUIDs should trigger user input errors ASAP.
@Naatan
Ensure partial migration is always performed
878ae99
@Naatan
Simplify migration significantly
9f19652
@Naatan
Get rid of commitmediator so we don't riddle our codebase with legacy…
456d119 
… handling code
@Naatan
Fix nil check
458eb14
@Naatan
Fix test running off of invalid project
2abcd83
@mitchell-as
Merge branch 'version/0-43-0-RC2' into version/0-44-0-RC1
ff2ac9e
@Naatan
Merge pull request #3078 from ActiveState/mitchell/dx-2499-2
e930046 
Merge en-us.yaml to address merge conflict.
@Naatan
Fix comment
d6cf265
@Naatan
Wrap error
136a4dc
@Naatan
Ensure we don't write the same thing twice
65242ea
@Naatan
Wrap errors
dff6d4b
@Naatan
Merge pull request #3077 from ActiveState/DX-2521
40f2e7a 
Greatly simplify local order migration mechanic
@as-builds
Merge branch version/0-43-0-RC2 to adopt changes from PR #3079
6c55ade
@as-builds
Merge branch version/0-43-0-RC2 to adopt changes from PR #3074
fda2da7
@mitchell-as
Merge pull request #3075 from ActiveState/mitchell/dx-2475
1757e12 
Validate UUID for namespace arguments.
@mitchell-as
Include original webclient ID in auth and signup URLs.
8b77e01
@github-actions github-actions bot changed the base branch from version/0-44-0-RC1 to version/0-43-0-RC2 February 5, 2024 22:17
@mitchell-as mitchell-as marked this pull request as ready for review February 5, 2024 23:10
Naatan
Naatan requested changes Feb 6, 2024
View reviewed changes
Copy link
Member

@Naatan Naatan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is trying to merge v0.44 into v0.43?

@mitchell-as
Copy link
Contributor Author

Whoops, I didn't see this was supposed to be for v43. Sorry about that :(

@mitchell-as mitchell-as closed this Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Naatan Naatan Naatan requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mitchell-as @Naatan @MDrakos @as-builds