Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed artifact caching despite previously cached artifacts not existing. #3115

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

mitchell-as
Copy link
Contributor

@mitchell-as mitchell-as commented Feb 20, 2024

BugDX-2545 state tool should install from cache locally whenever possible, especially for init

@mitchell-as mitchell-as marked this pull request as ready for review February 20, 2024 17:13
@Naatan
Copy link
Member

Naatan commented Feb 20, 2024

@mitchell-as this fix seems to be around cleaning up, was this process somehow interrupting cache from being created / accessed?

@mitchell-as
Copy link
Contributor Author

@Naatan If the cleanup process failed, the just-downloaded artifact was never properly stored. Hence it was downloaded again as reported in the ticket.

@mitchell-as
Copy link
Contributor Author

@MDrakos ping

@mitchell-as mitchell-as merged commit 8f4199f into version/0-44-0-RC1 Feb 23, 2024
10 of 14 checks passed
@mitchell-as mitchell-as deleted the mitchell/dx-2545 branch February 23, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants