Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure dependencies are reset if there is user input #3197

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Ensure dependencies are reset if there is user input #3197

merged 1 commit into from
Mar 25, 2024

Conversation

Naatan
Copy link
Member

@Naatan Naatan commented Mar 25, 2024 •
edited by github-actions bot
Loading

BugDX-2655 `state publish` failing on version constraint on master

For whatever reason this line existed on v0.43, but not on v0.44:

cli/internal/runners/publish/publish.go

Line 326 in e85cd5d

r.Dependencies = []request.PublishVariableDep{}

Likely a bad merge. This brings it back into v0.44, as well as considers the other ways dependencies can be specified.

@github-actions github-actions bot changed the base branch from master to version/0-43-0-RC5 March 25, 2024 21:37
@Naatan Naatan requested a review from mitchell-as March 25, 2024 21:38
mitchell-as
mitchell-as requested changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@mitchell-as mitchell-as left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you started on the wrong branch? Too many changes.

@Naatan Naatan changed the base branch from version/0-43-0-RC5 to version/0-44-0-RC1 March 25, 2024 21:48
@Naatan
Copy link
Member Author

Naatan commented Mar 25, 2024

@mitchell-as my bad, I needed to target v0.44, because v0.43 is fine as is.

@Naatan Naatan requested a review from mitchell-as March 25, 2024 21:49
@Naatan Naatan merged commit 6f22afe into version/0-44-0-RC1 Mar 25, 2024
13 checks passed
@Naatan Naatan deleted the DX-2655 branch March 25, 2024 22:00
as-builds added a commit that referenced this pull request Mar 25, 2024
@as-builds
Merge branch version/0-44-0-RC1 to adopt changes from PR #3197
06890b3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitchell-as mitchell-as mitchell-as approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Naatan @mitchell-as