-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use state revert REMOTE
instead of state revert HEAD
.
#3208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convert from HEAD to REMOTE, but show a deprecation message.
mitchell-as
commented
Apr 1, 2024
internal/locale/locales/en-us.yaml
Outdated
@@ -1138,6 +1138,9 @@ err_user_network_solution: | |||
If your issue persists consider reporting it on our forums at {{.V0}}. | |||
err_user_libc_solution: | |||
other: If you specified a glibc version, please check it is configured → [ACTIONABLE]{{.V0}}[/RESET]. | |||
warn_revert_head: | |||
other: | | |||
[NOTICE]DEPRECATION WARNING[/RESET]: `state revert HEAD` has been deprecated in favor of `[ACTIONABLE]state revert REMOTE[/RESET]`. Please use `[ACTIONABLE]state revert REMOTE[/RESET]` instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ticket did not give me a message I should be using, so let me know if this should be changed to something else.
Naatan
requested changes
Apr 1, 2024
Co-authored-by: Nathan Rijksen <nathanr@activestate.com>
Naatan
requested changes
Apr 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry didn't notice first pass.
Co-authored-by: Nathan Rijksen <nathanr@activestate.com>
Naatan
previously approved these changes
Apr 2, 2024
This reverts commit 1d80d3b.
Naatan
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert from HEAD to REMOTE, but show a deprecation message.