Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use state revert REMOTE instead of state revert HEAD. #3208

Merged
merged 4 commits into from
Apr 2, 2024

Conversation

mitchell-as
Copy link
Contributor

@mitchell-as mitchell-as commented Apr 1, 2024

TaskDX-2674 As a user I can use intuitive terms to reference the local / remote project

Convert from HEAD to REMOTE, but show a deprecation message.

Convert from HEAD to REMOTE, but show a deprecation message.
@@ -1138,6 +1138,9 @@ err_user_network_solution:
If your issue persists consider reporting it on our forums at {{.V0}}.
err_user_libc_solution:
other: If you specified a glibc version, please check it is configured → [ACTIONABLE]{{.V0}}[/RESET].
warn_revert_head:
other: |
[NOTICE]DEPRECATION WARNING[/RESET]: `state revert HEAD` has been deprecated in favor of `[ACTIONABLE]state revert REMOTE[/RESET]`. Please use `[ACTIONABLE]state revert REMOTE[/RESET]` instead.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ticket did not give me a message I should be using, so let me know if this should be changed to something else.

@mitchell-as mitchell-as requested a review from Naatan April 1, 2024 22:31
@mitchell-as mitchell-as marked this pull request as ready for review April 1, 2024 22:31
internal/locale/locales/en-us.yaml Outdated Show resolved Hide resolved
Co-authored-by: Nathan Rijksen <nathanr@activestate.com>
@mitchell-as mitchell-as requested a review from Naatan April 1, 2024 22:40
Copy link
Member

@Naatan Naatan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry didn't notice first pass.

internal/locale/locales/en-us.yaml Show resolved Hide resolved
Co-authored-by: Nathan Rijksen <nathanr@activestate.com>
@mitchell-as mitchell-as requested a review from Naatan April 1, 2024 22:50
Naatan
Naatan previously approved these changes Apr 2, 2024
@mitchell-as mitchell-as merged commit 669dbeb into version/0-44-0-RC1 Apr 2, 2024
7 checks passed
@mitchell-as mitchell-as deleted the mitchell/dx-2674 branch April 2, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants