Handle duplicate artifact events at the source #3210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Naatan
commented
Apr 2, 2024
•
Naatan
commented
 DX-2697 Failed to add or update artifact bar: Artifact bar already exists
|
|
@mdrohmann flagged you for review since you know this API and can weigh in on whether this is appropriate. If the API is expected to send the same event twice in certain scenario's we should not be logging this as critical (which means it goes to rollbar). |
mdrohmann
reviewed
Apr 3, 2024
There was a problem hiding this comment.
It is currently possible for the buildlogstreamer to send the same event twice. This happens, when nomad looses track of a build job and the HC re-schedules it. In this case, the job might actually be run twice. It appears that the amount of times, we loose track of a build, has increased since we are using nomad, but it always was a possible state.
MDrakos
approved these changes
Apr 4, 2024
as-builds
added a commit
that referenced
this pull request
Apr 4, 2024
as-builds
added a commit
that referenced
this pull request
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.