state artifacts lists all available artifacts
#3241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Naatan
commented
Apr 10, 2024
•
Naatan
commented
 DX-2727 `state artifacts` reports on all targets in the buildscript
|
mitchell-as
previously approved these changes
Apr 10, 2024
| @@ -76,6 +78,8 @@ type structuredArtifact struct { | |||
| URL string `json:"url"` | |||
| } | |||
|
|
|||
| const DefaultTarget = "__all__" | |||
There was a problem hiding this comment.
nit: It might be worth commenting where this value comes from, as we're in a runner and not in the buildplanner package or whatever else may help shed light on this value.
Actually, now that I think about it, maybe this constant should live somewhere in the runtime package and we refer to it in this file?
mitchell-as
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.