Increase state-svc wait timeout and output a notice after 5 seconds of waiting. #3269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mitchell-as
commented
Apr 29, 2024
•
mitchell-as
commented
 DX-2742 Increase state-svc timeout
|
mitchell-as
force-pushed
the
mitchell/dx-2742
branch
2 times, most recently
from
e4abc5b
to
8a2d7f5
Compare
mitchell-as
force-pushed
the
mitchell/dx-2742
branch
from
8a2d7f5
to
acc2d5b
Compare
mitchell-as
commented
Apr 29, 2024
| "github.com/ActiveState/cli/internal/profile" | ||
| ) | ||
|
|
||
| var ( | ||
| pingRetryIterations = 32 | ||
| pingRetryIterations = 45 |
There was a problem hiding this comment.
Using VERBOSE=true and trial and error I found this iteration gives a 31s timeout, which is close to the 30s target in the ACs. The previous iteration gave a 12s timeout.
Naatan
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.