Enable state publish integration tests.
#3290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchell-as
force-pushed
the
mitchell/dx-2739
branch
7 times, most recently
from
b9c3a27
to
a497515
Compare
Publish under 'private/ActiveState-CLI-Testing/<UUID>' namespace for each test run.
mitchell-as
force-pushed
the
mitchell/dx-2739
branch
from
a497515
to
3b42304
Compare
Naatan
requested changes
May 7, 2024
test/integration/publish_int_test.go
Outdated
| @@ -462,6 +466,8 @@ authors: | |||
| } | |||
| }) | |||
| } | |||
|
|
|||
| ts.IgnoreLogErrors() | |||
There was a problem hiding this comment.
What is this ignoring? Please add a comment if we truly want this.
There was a problem hiding this comment.
There are test cases that test failures, like omitting a filename or being unable to edit a description. These expected failures will be written to the log and cause nightly integration failures.
We have similar precedent for other integration tests that induce failures and verify that they actually do fail (and gracefully).
I've added a comment.
Naatan
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Publish under 'private/ActiveState-CLI-Testing/' namespace for each test run.