Report build success on heartbeat if we're not waiting for any more artifacts. #3344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mitchell-as
commented
Jun 5, 2024
•
mitchell-as
commented
 DX-2874 Build log is bogus
|
Naatan
requested changes
Jun 5, 2024
There was a problem hiding this comment.
I think this is signalling a greater issue. Which is that we're not instrumenting buildSuccess() properly.
It seems stillWaiting() is based on artifactsDone(), which gets populated by both the ArtifactSucceeded as well as the ArtifactFailed events. So already that's a bug; we cannot say that len(stillWaiting())==0 means the build was successful, only that we're "done".
I suggest updating buildSuccess() to buildFinished() as well as the terms it logs to the buildlog to say "finished" rather than "successful".
And we should have the conditional logic you introduced on heartbeat here instead be on ArtifactFailed, because waiting till the heartbeat doesn't feel necessary.
…act build failures.
Naatan
approved these changes
Jun 5, 2024
Comment on lines
+165
to
+170
| status := "Succeeded" | ||
| var event events.Eventer = events.BuildSuccess{} | ||
| if anyFailures { | ||
| status = "Failed" | ||
| event = events.BuildFailure{} | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.