Review iteration DX-2981 #3451
Merged
Review iteration DX-2981 #3451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Naatan
commented
Aug 16, 2024
| params.Branch = archive.Branch | ||
| } else if err := ns.Set(params.Namespace); err != nil { |
There was a problem hiding this comment.
ns.Set() exists to satisfy and work with the captain flag/argument mechanic. There's no point in using it in this context.
Note the AllowOmitOwner behaviour in ns.Set() is not relevant for checkout, and is again meant to address the flag/argument use-case. We should ideally have separated the types for "namespace" and "namespace flag". Don't wanna go that far for this PR though.
mitchell-as
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mitchell-as turns out I was again wrong on my recollection regarding the progress indication :p Your most recent changes are perfect, and remove the ambiguity I kept stumbling over. So your changes actually clean this up very nicely.
That said I did want to experiment with the
nsstuff as your comment didn't quite connect for me, hence the PR.