-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge "PATH" with Window's "Path". #3465
Conversation
This enables searching for exes in not just runtime PATH, but also Windows Path.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I may lack context here, but intuitively this feels wrong to me. If Windows is case insensitive then setting it to the sensitivity windows "assumes" doesn't solve anything. It sounds like the issue stems from us treating PATH as case sensitive on Windows, when it is not.
I think we need to make a larger change that has us always use Path
on Windows for consistency, but also has us respecting case insensitive PATH matches.
It seems that this was always "broken" and we're just now realizing, right? So perhaps fixing the bug at hand and filing a story for a larger refactor is appropriate here. ie. your proposed solution for updating JUST state exec
.
This reverts commit aa415e3.
Our runtime.json files use PATH, but Windows uses Path. Workaround this for now.
Okay, I've worked around this and filed DX-3030 in response. Yes, I believe we just uncovered this bug that was already there, and that this was always "broken". |
Test failures are unrelated to this PR. |
Merge "PATH" with Window's "Path".
This enables searching for exes in not just runtime PATH, but also Windows Path.
I believe this PR triggered the issue: d881640, but I think it exposed the fact we aren't merging
PATH
andPath
on Windows.