Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge "PATH" with Window's "Path". #3465

Merged
merged 3 commits into from
Aug 28, 2024
Merged

Conversation

mitchell-as
Copy link
Contributor

@mitchell-as mitchell-as commented Aug 27, 2024

BugDX-3012 Windows - `state exec` regression

This enables searching for exes in not just runtime PATH, but also Windows Path.

I believe this PR triggered the issue: d881640, but I think it exposed the fact we aren't merging PATH and Path on Windows.

This enables searching for exes in not just runtime PATH, but also Windows Path.
@mitchell-as mitchell-as marked this pull request as ready for review August 27, 2024 22:02
Copy link
Member

@Naatan Naatan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I may lack context here, but intuitively this feels wrong to me. If Windows is case insensitive then setting it to the sensitivity windows "assumes" doesn't solve anything. It sounds like the issue stems from us treating PATH as case sensitive on Windows, when it is not.

I think we need to make a larger change that has us always use Path on Windows for consistency, but also has us respecting case insensitive PATH matches.

It seems that this was always "broken" and we're just now realizing, right? So perhaps fixing the bug at hand and filing a story for a larger refactor is appropriate here. ie. your proposed solution for updating JUST state exec.

Our runtime.json files use PATH, but Windows uses Path. Workaround this for now.
@mitchell-as
Copy link
Contributor Author

mitchell-as commented Aug 28, 2024

Okay, I've worked around this and filed DX-3030 in response. Yes, I believe we just uncovered this bug that was already there, and that this was always "broken".

@mitchell-as
Copy link
Contributor Author

Test failures are unrelated to this PR.

@mitchell-as mitchell-as reopened this Aug 28, 2024
@mitchell-as mitchell-as merged commit 2c937dc into version/0-47-0-RC1 Aug 28, 2024
11 of 13 checks passed
@mitchell-as mitchell-as deleted the mitchell/dx-3012 branch August 28, 2024 20:40
mitchell-as added a commit that referenced this pull request Sep 5, 2024
Merge "PATH" with Window's "Path".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants