Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not re-link or re-copy a deployed file if it still exists. #3477

Merged
merged 3 commits into from
Sep 4, 2024

Conversation

mitchell-as
Copy link
Contributor

@mitchell-as mitchell-as commented Sep 4, 2024

BugDX-3037 INIT command fail with CRITICAL error

@mitchell-as mitchell-as marked this pull request as ready for review September 4, 2024 15:28
Copy link
Member

@Naatan Naatan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels too vague, we uninstalled the artifact and so the files it owns should be gone. We're finding that this is not the case, which suggests there's an issue somewhere either with removing the files or with tracking the installed files. We need to address this issue at the root.

I can't recall; are we tracking which artifact owns the file? Or are we just tracking all files an artifact cares about regardless of whether they are the owner? We need to be doing the former.

@mitchell-as
Copy link
Contributor Author

I agree, it didn't feel right. After Mark gave me the ability to reproduce it, I found that we're considering artifact deployments outside the current one. Oops. We should only consider artifact deployments targetting the current one for re-linking and re-copying.

We only see this when there are multiple deployments on a given machine. We aren't seeing this on CI because we use a clean cache, etc. for each test.

@mitchell-as mitchell-as merged commit 0880873 into version/0-46-0-RC1 Sep 4, 2024
8 checks passed
@mitchell-as mitchell-as deleted the mitchell/dx-3037 branch September 4, 2024 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants