Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved distribution system for conda-forge and pip #455

Merged
merged 41 commits into from
Jul 23, 2021
Merged

Conversation

jpn--
Copy link
Member

@jpn-- jpn-- commented Jul 13, 2021

Continues work from #440 on distribution system.

@jpn-- jpn-- marked this pull request as draft July 13, 2021 21:35
@coveralls
Copy link

coveralls commented Jul 14, 2021

Coverage Status

Coverage increased (+2.5%) to 58.815% when pulling c0aa3bf on condaforge-dev into 85f48ac on develop.

jpn-- added 2 commits July 14, 2021 09:14
- one -m arg in run
- coveralls after tests in travis
@jpn-- jpn-- requested a review from bstabler July 16, 2021 22:43
@jpn-- jpn-- marked this pull request as ready for review July 19, 2021 15:08
@bstabler
Copy link
Contributor

bstabler commented Jul 20, 2021

@jpn-- generally looks good. I have some specific comments:

  • I think we should PR to develop so we can accept this without having to also release it (since master always has the released code). I'd like to make some doc updates after we accept this as well. If you agree, can you change this PR to develop?
  • The new chunking command line argument is in GB as opposed to bytes like the actual setting. I find this confusing. I think they should be consistent.
  • gettingstarted.rst refers to python 3.8
  • Please remove all the optional tags in HOW_TO_RELEASE.md. Let's make the steps more straightforward and the optional items are just good to do anyway.
  • HOW_TO_RELEASE.md should refer to doing PRs to develop (assuming we decide to PR to develop)
  • development.rst Develop Install section refers to using pip to install/uninstall. I think this should now be conda forge.
  • development.rst Releases should now refer to HOW_TO_RELEASE.md

And a couple items to note:

  • I think this should be v1.1.0 since we're releasing several improvements - build process, orca, pandas 1.3, and the faster maz to maz and chunking (after we do the merge on develop)
  • Thanks for adding that conda is no longer free for organizations with more than 200 employees. Are the miniforge instructions any different?

After the revisions and I accept, I'll test the process and make a few docs updates. I also want to merge in a few of the other PRs.

@jpn--
Copy link
Member Author

jpn-- commented Jul 20, 2021

@bstabler I like the idea of PR's to develop, and develop goes to master. I wrote up this change into development.rst an opened #461 to discuss/formally approve this plan.

@jpn--
Copy link
Member Author

jpn-- commented Jul 20, 2021

re miniforge: it is functionally identical to Miniconda, the only difference being that the default channel is set to conda-forge's free channel vs. the Anaconda Inc. paid channel.

@jpn-- jpn-- changed the base branch from master to develop July 20, 2021 20:58
This was referenced Jul 23, 2021
@bstabler bstabler merged commit 447d718 into develop Jul 23, 2021
@bstabler bstabler deleted the condaforge-dev branch July 23, 2021 20:27
@bstabler bstabler self-assigned this Jul 23, 2021
@bstabler bstabler mentioned this pull request Jul 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants