fix: add ability to set the log level via environment variable #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Friendly reminder here @ErikBjare |
ErikBjare
reviewed
Aug 21, 2021
There was a problem hiding this comment.
Sorry, got a bit distracted by the underscore in the env var (LOGLEVEL vs LOG_LEVEL) and forgot about this. But underscore or not doesn't really matter.
I have one suggestion though. If you're okay with it and it looks good (haven't tested it) I'll apply it and merge :)
Co-authored-by: Erik Bjäreholt <erik.bjareholt@gmail.com>
|
Slowpoke here, finally getting around to merging this. Thanks! |
ErikBjare
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in https://github.com/ActivityWatch/aw-client/pull/57/files this PR adds the ability to set the log level of all AW components via a ENV variable.