Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switched to using atexit instead of handling signals #21

Closed
wants to merge 1 commit into from

Conversation

ErikBjare
Copy link
Member

No description provided.

@johan-bjareholt
Copy link
Member

With this the modules do not even exit properly with SIGINT (ctrl+c) and doesn't handle when it crashes any better.

@ErikBjare
Copy link
Member Author

ErikBjare commented Jun 27, 2017

Oh, that sucks. I thought atexit was a neat way to manage cases like this.

Edit: Someone on SO apparently knew this

Do you think try: ...; finally: ... would work?

Alternatively we could just make all signals call sys.exit() which would trigger the atexit.

@ErikBjare
Copy link
Member Author

Won't merge, closing.

@ErikBjare ErikBjare closed this Aug 24, 2017
@ErikBjare ErikBjare deleted the dev/atexit branch August 24, 2017 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants