Skip to content

Commit 0cf0cec

Browse files
committed
VisTimeline: optimize event sorting.
Converting Date objects to string then comparing them is not much of a good idea.
1 parent 360a1dc commit 0cf0cec

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/visualizations/VisTimeline.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ export default {
108108
events = _.filter(events, e => e.duration > 1);
109109
console.log(`Filtered ${bucket.events.length - events.length} events`);
110110
}
111-
events = _.sortBy(events, e => e.timestamp);
111+
events.sort((a, b) => a.timestamp.valueOf() - b.timestamp.valueOf());
112112
_.each(events, e => {
113113
data.push([
114114
bucket.id,

0 commit comments

Comments
 (0)