Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

code for implementing POST method #9

Merged
merged 10 commits into from
Feb 7, 2019
Merged

code for implementing POST method #9

merged 10 commits into from
Feb 7, 2019

Conversation

Enshaedn
Copy link
Contributor

@Enshaedn Enshaedn commented Feb 5, 2019 •
edited
Loading

POST wiki for reference.

@Enshaedn Enshaedn added API Team Tasks assigned to the API Team Sprint 2 labels Feb 5, 2019
@Enshaedn Enshaedn added this to the Sprint #2 milestone Feb 5, 2019
@Enshaedn Enshaedn self-assigned this Feb 5, 2019
@Enshaedn Enshaedn mentioned this pull request Feb 6, 2019
Closed
ZakBrinlee
ZakBrinlee reviewed Feb 6, 2019
View reviewed changes
Copy link
Contributor

@ZakBrinlee ZakBrinlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good. No issues

@Enshaedn Enshaedn requested review from T-travis and a team and removed request for T-travis February 6, 2019 22:48
ZakBrinlee
ZakBrinlee approved these changes Feb 7, 2019
View reviewed changes
Copy link
Contributor

@ZakBrinlee ZakBrinlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good. No issues

@Enshaedn Enshaedn merged commit 817863d into dev Feb 7, 2019
@Enshaedn Enshaedn deleted the alex_feature/sprint2_POSTmethod branch February 7, 2019 01:12
@toddysm
Copy link

toddysm commented Feb 13, 2019

  • Time estimated and time spent?
  • Testing from others? Testing done by you?

@Enshaedn
Copy link
Contributor Author

Enshaedn commented Feb 13, 2019 •
edited
Loading

  • Time estimated and time spent?
  • Testing from others? Testing done by you?

Hi @toddysm - Please see the issue for the time estimate vs time spent.

As for testing, I did some, but it was mostly trial and error of POST requests. Seeing what was accepted/rejected, and the http codes returned.

@ZakBrinlee ZakBrinlee mentioned this pull request Feb 14, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@T-travis T-travis T-travis approved these changes

@ZakBrinlee ZakBrinlee ZakBrinlee approved these changes

Assignees

@Enshaedn Enshaedn

Labels
API Team Tasks assigned to the API Team Sprint 2
Projects
None yet
Milestone
Sprint #2
Development

Successfully merging this pull request may close these issues.
5 participants
@Enshaedn @toddysm @ZakBrinlee @T-travis @bmenaz