Skip to content

fix: SqlalchemyDataLayer fails on models with __init__ statement #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 22, 2020
Merged

fix: SqlalchemyDataLayer fails on models with __init__ statement #7

merged 1 commit into from
Apr 22, 2020

Conversation

pysalt
Copy link
Contributor

@pysalt pysalt commented Apr 21, 2020

Closes #6

Znbiz
Znbiz reviewed Apr 21, 2020
View reviewed changes
@mahenzon
Copy link
Collaborator

Please rebase this branch on develop, where the tests are passing

@pysalt pysalt force-pushed the 6-fix-sqlalchemy-datalayer-create-object branch from 352c25e to 2ca1cca Compare April 22, 2020 12:58
@coveralls
Copy link

coveralls commented Apr 22, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 18

  • 20 of 20 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 82.822%
Totals Coverage Status
Change from base Build 12: 0.2%
Covered Lines: 1268
Relevant Lines: 1531
💛 - Coveralls

@Znbiz
Copy link
Contributor

Znbiz commented Apr 22, 2020

It is necessary to make the error crash at the time of application initialization. Otherwise, it will pop up only in real time

@pysalt pysalt force-pushed the 6-fix-sqlalchemy-datalayer-create-object branch from 2ca1cca to 0b5ffbd Compare April 22, 2020 14:18
@pysalt pysalt force-pushed the 6-fix-sqlalchemy-datalayer-create-object branch from 0b5ffbd to dc44ae9 Compare April 22, 2020 15:47
@Znbiz Znbiz merged commit 7558e71 into develop Apr 22, 2020
@mahenzon mahenzon deleted the 6-fix-sqlalchemy-datalayer-create-object branch September 1, 2021 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Znbiz Znbiz Znbiz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

SqlalchemyDataLayer fails on models with __init__ statement

4 participants

@pysalt @mahenzon @coveralls @Znbiz