Add support for VPCEndpoint. #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #10 +/- ##
=========================================
+ Coverage 91.06% 91.4% +0.33%
=========================================
Files 8 8
Lines 582 605 +23
=========================================
+ Hits 530 553 +23
Misses 52 52
Continue to review full report at Codecov.
|
enzbang
approved these changes
Mar 12, 2018
adacore-bot
pushed a commit
that referenced
this pull request
Aug 21, 2025
By raising `ValueError` instead, it will avoid repeating everytime: ``` version = versions.get_version(SOME_VERSION) assert version is not None ``` Ref #10+
adacore-bot
pushed a commit
that referenced
this pull request
Aug 26, 2025
This will help further reduce the pattern: ```python version = versions.get_version(SOME_VERSION) assert version is not None ``` When doing: ```python blue_version = versions.get_version(BLUE_VERSION) green_version = versions.get_version(GREEN_VERSION) assert blue_version is not None assert green_version is not None ``` Instead we will have a class with `blue/green` properties to access the corresponding versions: ```python blue_version = versions.blue green_version = versions.green ``` Ref #10+
adacore-bot
pushed a commit
that referenced
this pull request
Aug 26, 2025
We mainly use `BlueGreenAliasConfiguration` as: ```python blue_version = versions.get_version(BLUE_VERSION) BlueGreenAliasConfiguration(blue_version.version) ``` So one thing is that the class should accept `GetAtt`, but it can also directly accept `Version` so there is less risk to pass a wrong ARN Ref #10+
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.