Improve the archive API with fileobj parameters #595
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The archive API only allows unpacking an archive from file, and writing an archive to file. However the zipfile, and tarfile modules this API is based on, both accept fileobj parameters to read from, and write to memory. This change adds a fileobj parameter to create_archive, and unpack_archive, in order to allow creating archives to, and unpacking archives from memory.
RomaricKanyamibwa
approved these changes
May 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The archive API only allows unpacking an archive from file, and writing an archive to file. However the zipfile, and tarfile modules this API is based on, both accept fileobj parameters to read from, and write to memory.
This change adds a fileobj parameter to create_archive, and unpack_archive, in order to allow creating archives to, and unpacking archives from memory.