Remove Clone bound on map_tabs and filter_map_tabs
#241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adanos020
reviewed
Jun 2, 2024
I guess i just removed it from the stuff i used and didn't check for other instances of it. |
Adanos020
approved these changes
Jul 3, 2024
Adanos020
force-pushed
the
map_tabs_remove_clone
branch
from
3697626
to
28f7bb5
Compare
Merged
Adanos020
added a commit
that referenced
this pull request
Oct 2, 2024
* Remove `Clone` bound on `map_tabs` and `filter_map_tabs` (#241) * remove Clone bound on map_tabs and filter_map_tabs * remove Clone bound from all functions with Clone + FnMut bounds * Update changelog * Add missing period in changelog --------- Co-authored-by: Adanos020 <adanos020@gmail.com> * Update crate version and add MSRV change to changelog * Fix heading type in changelog * Update duplicate to 2.0 (#248) * Egui 0.29 (#251) * Upgrade to egui 0.29. * Update changelog and readme * Update release date in changelog --------- Co-authored-by: Ved_s <vedomir.samarin.03@gmail.com> Co-authored-by: Tau Gärtli <git@tau.garden>
Adanos020
added a commit
that referenced
this pull request
Oct 19, 2024
… on each tab bar (#237) * Correct comment typos * Add two buttons on tab bars - Close all tabs: "×" - Collapse all tabs: "▼" * Add some utility for recursive node collapse checking * Preliminary implementation of collapsing windows * Handle tab collapsing layout * Resize windows when subnodes collapsed * Implements leaf close all button * Update changelog * Allow dragging to a collapsed leaf * Fix collapsed state checking after dnd splits * Update examples * Update changelog * Fix up changelog after rebase * Fix failing test and rename `Translations::window` to `Translations::leaf`. * Remove `Clone` bound on `map_tabs` and `filter_map_tabs` (#241) * remove Clone bound on map_tabs and filter_map_tabs * remove Clone bound from all functions with Clone + FnMut bounds * Update changelog * Add missing period in changelog --------- Co-authored-by: Adanos020 <adanos020@gmail.com> * Update crate version and add MSRV change to changelog * Fix heading type in changelog * Fix tab bar scroll bar width on window surfaces * Add close window button in context menu * Add minimize window button * Update CHANGELOG.md * Fix cargo test * Add tooltips to right-clickable tab bar buttons * Add minimization activation with modifiers * Add close window with modifiers * Correct tooltip display conditions * Upgrade to egui 0.29 * Add secondary button feature toggle * Cleanup code * Update examples * Fix cursor icon logic * Update examples * Update changelog * Make Japanese translations in the example more consistent with each other --------- Co-authored-by: Adanos020 <adanos020@gmail.com> Co-authored-by: Ved_s <vedomir.samarin.03@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No point of having a FnMut if it can't mutably reference stuff outside