Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.mobileconfig generator #2497

Open
ameshkov opened this issue Dec 27, 2020 · 9 comments
Open

.mobileconfig generator #2497

ameshkov opened this issue Dec 27, 2020 · 9 comments

Comments

@ameshkov
Copy link
Member

ameshkov commented Dec 27, 2020

We may need a more robust .mobileconfig generator dialog that would allow configuring it.

What could be included:

@ammnt
Copy link

ammnt commented Dec 28, 2020

@ameshkov, are you really sure AGH can't sign and encrypt these files? This is implemented on the NextDNS🤫

@ameshkov
Copy link
Member Author

Signing requires a developer certificate, we wouldn't use ours to sign user-generated configuration profiles, this is dangerous.

@ammnt
Copy link

ammnt commented Dec 28, 2020

@ameshkov, to solve this problem, they somehow encrypt these files - I can send you an example of such a file:

image

Isn't that gonna help?

@ameshkov
Copy link
Member Author

That's how a signed configuration profile looks like, it's not encryption. And this still does not solve any issues, we can't allow third-parties to sign a configuration profile with our developer certificate.

@ammnt
Copy link

ammnt commented Dec 28, 2020

That's how a signed configuration profile looks like, it's not encryption. And this still does not solve any issues, we can't allow third-parties to sign a configuration profile with our developer certificate.

Ah, okay... Got it✌️

@ameshkov
Copy link
Member Author

Don't get me wrong, it's just if we sign someone's configuration profile, it would look like it comes from us. But it will point to a DNS server that is not controlled by us. And there is quite a lot of nasty stuff that can be done when you operate a DNS server, we don't want to be responsible for that.

@ammnt
Copy link

ammnt commented Jan 31, 2021

@ameshkov, please, add bootstrap server address strings for initial resolving. Here is example:

<key>ServerAddresses</key>
				<array>
					<string>2606:4700:4700::1111</string>
					<string>2606:4700:4700::1001</string>
					<string>1.1.1.1</string>
					<string>1.0.0.1</string>
				</array>

Thank you🤗

@ZeroClover
Copy link

ZeroClover commented Mar 10, 2021

Signing requires a developer certificate, we wouldn't use ours to sign user-generated configuration profiles, this is dangerous.

@ameshkov AGH can use its own TLS certificate (to use DoH, the user would obviously need to set up a TLS certificate in AGH) to sign mobileconfig, as NextDNS does the same thing.

Screenshot:

IMG_0065

IMG_0066

adguard pushed a commit that referenced this issue Jun 1, 2021
Merge in DNS/adguard-home from 3172-mobileconfig to master

Updates #3172.
Updates #2497.

Squashed commit of the following:

commit 30549ef
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Tue Jun 1 21:00:17 2021 +0300

    all: log changes

commit 9b94294
Author: Ildar Kamalov <ik@adguard.com>
Date:   Tue Jun 1 17:56:59 2021 +0300

    client: always show port input

commit 6d6a0bd
Merge: 13a3bff 77946a7
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Tue Jun 1 17:50:41 2021 +0300

    Merge branch 'master' into 3172-mobileconfig

commit 13a3bff
Author: Ildar Kamalov <ik@adguard.com>
Date:   Tue Jun 1 17:20:17 2021 +0300

    client: add port to mobile config form

commit f6abe0b
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Mon May 31 19:43:37 2021 +0300

    home: imp cyclo

commit c304a0b
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Mon May 31 18:19:46 2021 +0300

    home: reduce allocs

commit 10a7678
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Mon May 24 20:05:08 2021 +0300

    all: make the host parameter required
@fishermanG
Copy link

Any update on this? I already have LE certificates configured under the Encryption Settings but .mobileconfig still remains unsigned.

I had to use OpenSSL smime to sign the file. Not too difficult. Would be heck of a life saver if this auto signing can be implemented in AGH.

heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this issue Mar 20, 2023
Merge in DNS/adguard-home from 3172-mobileconfig to master

Updates AdguardTeam#3172.
Updates AdguardTeam#2497.

Squashed commit of the following:

commit 30549ef
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Tue Jun 1 21:00:17 2021 +0300

    all: log changes

commit 9b94294
Author: Ildar Kamalov <ik@adguard.com>
Date:   Tue Jun 1 17:56:59 2021 +0300

    client: always show port input

commit 6d6a0bd
Merge: 13a3bff 77946a7
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Tue Jun 1 17:50:41 2021 +0300

    Merge branch 'master' into 3172-mobileconfig

commit 13a3bff
Author: Ildar Kamalov <ik@adguard.com>
Date:   Tue Jun 1 17:20:17 2021 +0300

    client: add port to mobile config form

commit f6abe0b
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Mon May 31 19:43:37 2021 +0300

    home: imp cyclo

commit c304a0b
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Mon May 31 18:19:46 2021 +0300

    home: reduce allocs

commit 10a7678
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Mon May 24 20:05:08 2021 +0300

    all: make the host parameter required
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants