-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug in mobileconfig #3172
Comments
@attinderdhillon, the first point is definitely a bug. We're already working on fixing it. The second point is an expected behavior. See "Clients" section of our wiki. |
DNS-over-TLS So I assume we need to add a DNS entry for this to work? I believe many of us are using sub-domains for adguard (dns.example.com) , multi-level wildcards are not supported AFAIK. Kindly look into the possibility of using hyphens ex. clientid-dns.example.com. |
We have already discussed using hyphens and decided to reject the idea, since that would exclude hyphens from client IDs themselves. For example, in There is no such problem with DNS-over-HTTPS since client ID is used as part of URL there. So you may want to use that. |
Merge in DNS/adguard-home from 3172-mobileconfig to master Updates #3172. Updates #2497. Squashed commit of the following: commit 30549ef Author: Eugene Burkov <e.burkov@adguard.com> Date: Tue Jun 1 21:00:17 2021 +0300 all: log changes commit 9b94294 Author: Ildar Kamalov <ik@adguard.com> Date: Tue Jun 1 17:56:59 2021 +0300 client: always show port input commit 6d6a0bd Merge: 13a3bff 77946a7 Author: Eugene Burkov <e.burkov@adguard.com> Date: Tue Jun 1 17:50:41 2021 +0300 Merge branch 'master' into 3172-mobileconfig commit 13a3bff Author: Ildar Kamalov <ik@adguard.com> Date: Tue Jun 1 17:20:17 2021 +0300 client: add port to mobile config form commit f6abe0b Author: Eugene Burkov <e.burkov@adguard.com> Date: Mon May 31 19:43:37 2021 +0300 home: imp cyclo commit c304a0b Author: Eugene Burkov <e.burkov@adguard.com> Date: Mon May 31 18:19:46 2021 +0300 home: reduce allocs commit 10a7678 Author: Eugene Burkov <e.burkov@adguard.com> Date: Mon May 24 20:05:08 2021 +0300 all: make the host parameter required
@attinderdhillon, hello! The fix for the issue is available in latest edge build. Could you please check if our solution work fine? |
Still port missing from Doh config.. |
@attinderdhillon, a few questions to clarify:
|
DNS-over-TLS: Use tls://dns.domain.com:853 string. Here's a list of software you can use.` 3 |
@attinderdhillon, as your "screenshot" says, the port is defined correctly and should be presented in the resulting URL. However, the fix only affected the bottom part of the page, where the button for downloading the Could you please show this part? |
I don't have that option. |
@attinderdhillon, well, your version of AdGuard Home is v0.107.0-b.1 which is the first beta of v0.107.0. The fix is only included into edge builds for now. You can find the instructions on how to get it here. |
My Bad, Working fine in the edge built, Thank You. |
It's okay. Thanks for testing. Will close the issue for now. |
Merge in DNS/adguard-home from 3172-mobileconfig to master Updates AdguardTeam#3172. Updates AdguardTeam#2497. Squashed commit of the following: commit 30549ef Author: Eugene Burkov <e.burkov@adguard.com> Date: Tue Jun 1 21:00:17 2021 +0300 all: log changes commit 9b94294 Author: Ildar Kamalov <ik@adguard.com> Date: Tue Jun 1 17:56:59 2021 +0300 client: always show port input commit 6d6a0bd Merge: 13a3bff 77946a7 Author: Eugene Burkov <e.burkov@adguard.com> Date: Tue Jun 1 17:50:41 2021 +0300 Merge branch 'master' into 3172-mobileconfig commit 13a3bff Author: Ildar Kamalov <ik@adguard.com> Date: Tue Jun 1 17:20:17 2021 +0300 client: add port to mobile config form commit f6abe0b Author: Eugene Burkov <e.burkov@adguard.com> Date: Mon May 31 19:43:37 2021 +0300 home: imp cyclo commit c304a0b Author: Eugene Burkov <e.burkov@adguard.com> Date: Mon May 31 18:19:46 2021 +0300 home: reduce allocs commit 10a7678 Author: Eugene Burkov <e.burkov@adguard.com> Date: Mon May 24 20:05:08 2021 +0300 all: make the host parameter required
If adguard is on a non-standard HTTPS port. The "iOS and macOS configuration" for DNS-over-HTTPS doesn't add the Port to the query URL.
For "DNS-over-TLS" If a client ID is specified it is prefixed to the URL.
In both cases, the URL is not reachable and DNS fail.
The text was updated successfully, but these errors were encountered: