Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox extension stops working if user disables cookies #940

Closed
ameshkov opened this issue Jan 24, 2018 · 9 comments
Closed

Firefox extension stops working if user disables cookies #940

ameshkov opened this issue Jan 24, 2018 · 9 comments

Comments

@ameshkov
Copy link
Member

ameshkov commented Jan 24, 2018

It seems that disabling cookies prevents access to the extension's own localStorage and that breaks settings.

We should alert user if we detected a situation like that and provide an instruction:
#940 (comment)

@ameshkov ameshkov added this to the 2.9 milestone Jan 24, 2018
@corvo7
Copy link

corvo7 commented Feb 1, 2018

Hi:) We are waiting for the solution of the problem ...

@Mizzick
Copy link
Contributor

Mizzick commented Feb 15, 2018

It is possible to add our extension to cookies whitelist with moz-extension://[Internal UUID] address, that could be obtained from about:debugging tab.

Please check this instructions for more details:
https://www.ghacks.net/2017/10/10/how-to-deal-with-firefox-extensions-that-require-cookies/

@Mizzick Mizzick closed this as completed Feb 19, 2018
@ameshkov ameshkov removed this from the 2.9 milestone Feb 19, 2018
@ameshkov
Copy link
Member Author

@The-Commissioner it's not about cookies, it is about localStorage and indexedDB, and this is a common practice to use both to store add-on settings.

@ameshkov
Copy link
Member Author

Blocking cookies also blocks indexedDB and localStorage, that's the whole point -- user has disabled cookies and we ended up with localStorage and indexedDB that do not persist their state.

@ameshkov
Copy link
Member Author

ameshkov commented Feb 20, 2018

That's not about localStorage, this is about another entity -- "browser.storage"

@ameshkov
Copy link
Member Author

As I can see, uBO also uses indexedDB. It may not look like it's broken, but it actually is -- filters content and caches aren't persisted and loaded from defaults every time. Actually, I think that both ways are not okay.

We'd better let users know that one of the components is not working as it should, and provide an instruction.

@ameshkov
Copy link
Member Author

You can't see it, but if you debug it and find indexedDB usages, you'll see what I am talking about.

@Mizzick
Copy link
Contributor

Mizzick commented Nov 20, 2018

So, do we need to show some warning to user in case cookies are disabled?

@Mizzick
Copy link
Contributor

Mizzick commented Nov 21, 2018

No longer reproducable with FF 59

@zzebrum zzebrum closed this as completed Feb 7, 2019
adguard pushed a commit that referenced this issue Jun 29, 2021
…th mouse

Merge in EXTENSIONS/browser-extension from feature/AG-8725 to feature/AG-2737

Squashed commit of the following:

commit 7a20149
Merge: 60b1dcf 0dbd167
Author: Vladimir Zhelvis <v.zhelvis@adguard.com>
Date:   Tue Jun 29 17:36:50 2021 +0300

    Merge branch 'feature/AG-2737' into feature/AG-8725

commit 60b1dcf
Merge: 56adb6e 9b9ba49
Author: Vladimir Zhelvis <v.zhelvis@adguard.com>
Date:   Tue Jun 29 17:29:23 2021 +0300

    Merge branch 'feature/AG-2737' into feature/AG-8725

commit 56adb6e
Author: Vladimir Zhelvis <v.zhelvis@adguard.com>
Date:   Tue Jun 29 15:48:38 2021 +0300

    fix comment

commit ad93e5b
Author: Vladimir Zhelvis <v.zhelvis@adguard.com>
Date:   Tue Jun 29 15:38:35 2021 +0300

    refactoring

commit 5645585
Author: Vladimir Zhelvis <v.zhelvis@adguard.com>
Date:   Tue Jun 29 15:27:21 2021 +0300

    refactoring

commit 6b531ca
Author: Vladimir Zhelvis <v.zhelvis@adguard.com>
Date:   Tue Jun 29 15:15:07 2021 +0300

    refactoring

commit 0a1d28f
Author: Vladimir Zhelvis <v.zhelvis@adguard.com>
Date:   Tue Jun 29 13:38:43 2021 +0300

    add filter vertical scroll
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants