-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Firefox extension stops working if user disables cookies #940
Comments
Hi:) We are waiting for the solution of the problem ... |
It is possible to add our extension to cookies whitelist with Please check this instructions for more details: |
@The-Commissioner it's not about cookies, it is about |
Blocking cookies also blocks indexedDB and localStorage, that's the whole point -- user has disabled cookies and we ended up with localStorage and indexedDB that do not persist their state. |
That's not about localStorage, this is about another entity -- "browser.storage" |
As I can see, uBO also uses indexedDB. It may not look like it's broken, but it actually is -- filters content and caches aren't persisted and loaded from defaults every time. Actually, I think that both ways are not okay. We'd better let users know that one of the components is not working as it should, and provide an instruction. |
You can't see it, but if you debug it and find indexedDB usages, you'll see what I am talking about. |
So, do we need to show some warning to user in case cookies are disabled? |
No longer reproducable with FF 59 |
…th mouse Merge in EXTENSIONS/browser-extension from feature/AG-8725 to feature/AG-2737 Squashed commit of the following: commit 7a20149 Merge: 60b1dcf 0dbd167 Author: Vladimir Zhelvis <v.zhelvis@adguard.com> Date: Tue Jun 29 17:36:50 2021 +0300 Merge branch 'feature/AG-2737' into feature/AG-8725 commit 60b1dcf Merge: 56adb6e 9b9ba49 Author: Vladimir Zhelvis <v.zhelvis@adguard.com> Date: Tue Jun 29 17:29:23 2021 +0300 Merge branch 'feature/AG-2737' into feature/AG-8725 commit 56adb6e Author: Vladimir Zhelvis <v.zhelvis@adguard.com> Date: Tue Jun 29 15:48:38 2021 +0300 fix comment commit ad93e5b Author: Vladimir Zhelvis <v.zhelvis@adguard.com> Date: Tue Jun 29 15:38:35 2021 +0300 refactoring commit 5645585 Author: Vladimir Zhelvis <v.zhelvis@adguard.com> Date: Tue Jun 29 15:27:21 2021 +0300 refactoring commit 6b531ca Author: Vladimir Zhelvis <v.zhelvis@adguard.com> Date: Tue Jun 29 15:15:07 2021 +0300 refactoring commit 0a1d28f Author: Vladimir Zhelvis <v.zhelvis@adguard.com> Date: Tue Jun 29 13:38:43 2021 +0300 add filter vertical scroll
It seems that disabling cookies prevents access to the extension's own localStorage and that breaks settings.
We should alert user if we detected a situation like that and provide an instruction:
#940 (comment)
The text was updated successfully, but these errors were encountered: