Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fuckfuckadblock #196

Closed
FadeMind opened this issue May 12, 2019 · 23 comments
Closed

fuckfuckadblock #196

FadeMind opened this issue May 12, 2019 · 23 comments
Assignees

Comments

@FadeMind
Copy link

Hi, Please consider adding https://github.com/bogachenko/fuckfuckadblock/blob/master/fuckfuckadblock.txt
list with lots of script blocking lots of ads script - pop-ups and anti-adblock bypass.

P.S. Why CoinBlockerLists is not available in LIST Adguard For Windows App? (was included?)

@ameshkov ameshkov self-assigned this May 12, 2019
@ameshkov
Copy link
Member

There're two issues with it:

  1. Troubling name, we cannot have outright swearing inside the product, despite our feelings towards FAB:)
  2. We do not allow using JS filters in third-party filter lists added here. However, when you add it as a custom filter list, you can explicitly allow JS filters and make it work.

P.S. Why CoinBlockerLists is not available in LIST Adguard For Windows App? (was included?)

Nope, I am troubled with its license (GPL Affero is quite strict) and not sure if we can add it. Waiting for a lawyer's comment now.

@FadeMind
Copy link
Author

@ameshkov you can FORK FFA and renaming (MIT License), or simply MERGE with Yours CODE BLOB. I added some new reports and script from maintainer works well. See ref commit AdguardTeam/AdguardFilters#33665

Regards

@ameshkov
Copy link
Member

@FadeMind yeah, the maintainer does a great job indeed, but the point 2 still stands.

When we add scriptlets support to AG, we might allow them for third-party filter lists, that will solve the issue.

@bogachenko
Copy link

bogachenko commented Jul 10, 2019

@ameshkov Я не подгоняю, но есть ли примерная дата релиза скриптлетов для программы/расширения сафари. И кстати у вас есть календарь релизов, чо-то типа, как у тормозиллы https://wiki.mozilla.org/Release_Management/Calendar ? Планируете запилить нечто подобное? (и я сейчас говорю не об вашем блоге, я говорю о краткой таблице релиза, ключевое слово -- краткая)
Когда будет новая версия, текущая версия, + краткое описание, что изменено, что будет изменено.
У вас ох*нная база знаний, мои овации всем тем людям, кто ее делает, это божественно. Они большие молодцы. Создадите еще 1 страницу для подобной таблицы? Пжлст. Или это лишний геморрой?

Хорошего вам дня!

@ameshkov
Copy link
Member

@bogachenko привет!

Публичного календаря у нас нет, но вообще релизы у нас раз в 2-3 месяца выходят. Вот где-то месяца через 2 и будут скриптлеты.

Создадите еще 1 страницу для подобной таблицы? Пжлст. Или это лишний геморрой?

Мы просто не настолько четко планируем, чтобы это публичным делать:(

@lancelot-moon
Copy link

lancelot-moon commented Jul 16, 2019

We do not allow using JS filters in third-party filter lists added here.

@ameshkov
In AG Browser Extension, I don't see trusted symbol for those third-party filters in the default filters list.

But I see those third-party filters in the default filters list are marked as trusted in AG for Windows.
So JS filters in those third-party filters of the default filters list in AG for Windows/Mac will work, right?

@ameshkov
Copy link
Member

All filters that we re-host on our servers are marked as trusted by default.
However, we remove all dangerous rules from these re-hosted versions.

@lancelot-moon
Copy link

Are all third-party filters in the default filters list re-host in all AG products?
Ex: EasyList China, Adblock Warning Removal List...etc.
I supposed those third-party filters in the default filters list are subscribed from the official link.
Anyway, thanks for the information.

@ameshkov
Copy link
Member

@bogachenko вопрос - нас просят (не только тут) добавить твой фильтр в рекомендованные, но мы не можем из-за его названия. Есть ли опция замутить какой-то safe-for-work форк?

@bogachenko
Copy link

bogachenko commented Feb 21, 2020

@ameshkov можно легче - https://github.com/PolishFiltersTeam/PolishAnnoyanceFilters.netlify.com/blob/8dfe200e9f57651a4eca88db75ca9a544fc8c49e/data/FilterLists.toml#L269

Поляки не спрашивали, просто взяли и поменяли. Ну а я, то не против. С MIT лицензией можно делать все, что душе угодно.

@ameshkov
Copy link
Member

@bogachenko да со ссылкой на homepage проблема, название то сделать можно всякое. Ну ладно, может и такой вариант пройдет.

@bogachenko
Copy link

bogachenko commented Feb 21, 2020

@ameshkov

Ну ладно, может и такой вариант пройдет.
пройдет

Так, для тупых. Вы типа там голосуете за добавление?

@ameshkov
Copy link
Member

@bogachenko не, юзеры слабонервные могут расстроиться.

@bogachenko
Copy link

bogachenko commented Feb 21, 2020

@ameshkov Ну всем не угодишь, если сомневаешься - не добавляй. Пользователи сами найдут, если надо будет.


В любом случае создавать safe-for-work форк - не.

не, юзеры слабонервные могут расстроиться.

https://github.com/sitexw/FuckAdBlock/issues/42

🤣

@ameshkov
Copy link
Member

Время сейчас такое, триггерятся со всего

@FadeMind
Copy link
Author

@ameshkov What is big deal with FORK and using scriptlets from FFA DIRECTLY in Custom Named Adguard AntiAdblocks (R) 😉 separelly as standalone optional repository BASED on FFA and merged in period time? Second, Lots of fixes from FFA are not available in Adguard. (For example about:blank freak out some ignored by Adguard Filters Team, resolved in FFA). Some sites sometimes did not work properly, but at end REPORT and FEEDBACK from MAINTAINER is GOLDEN @bogachenko

@ameshkov
Copy link
Member

@FadeMind well, first of all, I'd like the real maintainer to get praised for the filter list.

What for the fixes, @Alex-302 do you know about these issues?

@FadeMind
Copy link
Author

@ameshkov take me some time for research and will post proper examples ;)

@Alex-302
Copy link
Member

do you know about these issues?

no.

@FadeMind
Copy link
Author

@lancelot-moon
Copy link

fuckfuckadblock causes some websites' comments not to be correctly shown.
People will be unable to leave comments on some websites with it.

@bogachenko
Copy link

bogachenko commented Feb 22, 2020

@FadeMind I deleted most of them
@lancelot-moon where?

@lancelot-moon
Copy link

@bogachenko
https://hiraku.tw/2020/02/6044/
With fuckfuckadblock, try commenting and then you'll find that some comment buttons are incorrectly blocked.
You'll be unable to "send" comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants