fix: use net_enode to retrieve Enode addresses #9
Conversation
fllaca
force-pushed
the
net_enode
branch
3 times, most recently
from
269a72e
to
c75078b
Compare
fllaca
force-pushed
the
net_enode
branch
2 times, most recently
from
c356917
to
0a6e134
Compare
There was a problem hiding this comment.
tested locally with expected output (connecting 4 validators)
connecting with both validators and permissioners with the fix here https://github.com/AdharaProjects/cluster-config-apps/pull/1371/files#diff-2c65a4818e188bc2f8f7e4db189b00dedc70f6123efcad4fba6ff035f68d3a0dR25
fllaca
force-pushed
the
net_enode
branch
2 times, most recently
from
6274e0c
to
4bb0e82
Compare
Dockerfile
Outdated
| @@ -2,6 +2,11 @@ FROM golang:1.14.0-buster as builder | |||
|
|
|||
| WORKDIR /workdir | |||
|
|
|||
| COPY ./go.mod /workdir/go.mod | |||
| COPY ./go.sum /workdir/go.suml | |||
There was a problem hiding this comment.
typo I think COPY ./go.sum /workdir/go.sum
| kind create cluster | ||
| ``` | ||
|
|
||
| 2. Apply example manifests |
There was a problem hiding this comment.
maybe these two points as well (just suggestion)
kubectl create namespace default(like used here https://github.com/Adhara-Tech/kubesu/pull/9/files?file-filters%5B%5D=.md&file-filters%5B%5D=.yml#diff-3ca6fa0450efd86b0719e8c49a79330fc15d296652b7e8923f2fa11224002a78R21)kind load docker-image docker.io/adharatech/kubesu:v0.0.1-rc5
There was a problem hiding this comment.
default namespace is created by default in kubernetes, it doesn't need to be created.
The second point about loading the docker-image won't be needed once v0.0.1-rc5 is published, but it's true that it can be handy having these instructions while developing. If you agree, I will think on a nice way to document this and open another PR with that extended documentation (like adding a DEVELOPING.md doc or something 🤔 )
There was a problem hiding this comment.
just the one comment
locally tested, looks correct:
0: 10.244.0.67 client-besu-0 ce7edc292d7b747fab2f23584bbafaffde5c8ff17cf689969614441e0527b90015ea9fee96aed6d9c0fc2fbe0bd1883dee223b3200246ff1e21976bdbc9a0fc8
1: 10.244.0.68 validator-besu-0 cc88932af38c9c8444930d52932df9ea220d520e0d32dba76f6c142d458ae5b6e76891a7c3bb5585e25d12e17600e704b388862dcfe97932a9ca45261cb53033
Checking node [client-besu-0]
add: validator-besu-0
Checking node [validator-besu-0]
add: client-besu-0
No description provided.