Dragonflight Patch V5 #790
Conversation
MleveK
commented
Nov 18, 2022
MleveK
commented
- Fixed Container issues
- Fixed Tooltip Processor
- Fixed GetContainerItemInfo
- Fixed ClassID and SubClassID Values
- Fixed Item Count
- Fixed Item Borders
- Fixed Filtering
- Fixed Icons (Textures)
- Added Reagent Bag
- Added Separate Free Space Count for Reagent Bag
|
Thank you for your work,, it's working great now :) I see you added a reagent bag for the bank too, but in my knowledge there isn't any. It's only for your bags. |
|
Huge Thanks @juntereiner for all of your feedback\debugging |
|
i see there is a fix for the reagent bag but i dont see any updates in curse, is there a seperate file somewhere here? |
|
@cindynico |
|
unzipped and pasted it to my addons. Didnt see any reagent bag when I logged in but I geuss thats merged with the other empty slots and not something visual like a categorie. Which is great work if it uses it auto. In anyway, thank you for the great work. I know people can be upset if something doesnt work but these problems arent something you can fix before a launch. Anyway just wanted to get that out there and again thank you all for the effort! |
|
Amazing work MieveK - only thought about coming on GitHub this morning - have been suffering with the Blizzard bag view since maintenance. AdiBags is one of my major 'quality of life' addons so glad to see it back working so quickly. |
|
I'll keep putting these here as I know it's easier for most to get. Added Reagent Bag under Freespace with RB Upgrade Arrow is back, and moved to see. (Pawn Addon Required) |
|
Sorry for spamming with so many files\fixes. |
Is this the same thing as https://github.com/AdiAddons/AdiBags/pull/790#issuecomment-1320925739 ? |
self.hasItem just gets reset to 1 for certain items for some reason, and Yeah that function was what was causing them to not update their border. But I didn't change that particular function though, I wasn't sure if the hasItem() function had any other reason to have 1 as false. I instead just reinitialized self.hasItem to True or False before updating the border. |
|
Amazing work! Any chance you could get Masque working? 😄 |
thank you vm. I am keeping this page open and come in to check once in a while :) |
|
@MleveK you need rebase branch with master, and a good job. |
- Fixed Container issues - Fixed Tooltip Processor - Fixed GetContainerItemInfo - Fixed ClassID and SubClassID Values - Fixed Item Count - Fixed Item Borders - Fixed Filtering - Fixed Icons (Textures) - Added Reagent Bag - Added Separate Free Space Count for Reagent Bag
Added checks for Retail for the new API changes.
Minor Fixes that we're introduced when I created the PR.
Removed Reagent Bag from Showing in Bank. Also Added 7th Bag which was Missing for the same reason.
Added condition for Retail.
Fixed Filtered (Search) Function and removed Debugs
- Re-enabled Pawn - Moved Pawn's upgrade arrow to bottom left to not interfere with item level - Reconfigured Free space for Reagent bag to be included under "Free Space" and has the tag RB. (Like Profession Bags) - Separated Reagent Bag from other bags in the bag slots and added a title to it - Reverted a few Icon changes that were made in the initial fix. - Renamed REAGENT to REAGENT_CONTAINER to keep uniformity
- Fixed when Clicking or Moving an item where the BorderGlow of some items would go away.
MleveK
force-pushed
the
df-prepatch-fixes
branch
from
e2ae030
to
a4fc8f4
Compare
|
Thank you @MleveK for all your incredible work here -- I'm going to test this branch late tomorrow/early Monday as time permits and will try to push a release early next week. I want to review the code in-depth and actually give real feedback when I'm back. |
|
One thing that would be immensely helpful, @MleveK, is if you could provide a larger description around your design decisions and why you chose to write things the way you did, i.e. how did you take into account future maintenance, portability between the various WoW products, etc. These will be the key areas that I will be looking at, beyond a binary "does it work or not" evaluation. Thanks! |
I've been using this version for a while and I get a lua error whenever moving an item to the "free space" button (pardon me if you've already fixed this) Error:
I was able to fix it by changing local quality = hasItem(self.hasItem) and (self.itemLink or self.itemId) and select(3, GetItemInfo(self.itemLink or self.itemId)) |
|
Getting this error when leaving auctionhouse -
|
|
Getting this error almost constantly when interacting with objects, etc.: 10x AdiBags/widgets/ItemButton.lua:500: Usage: GetItemInfo(itemID|"name"|"itemlink") |
|
@MleveK Thank you again for all your help. After taking a look at this PR and some of the other changes as done by @jnwhiteh, I'm going to work on another branch that incorporates a combination of the two + fix some other things along the way. I'm going to be releasing small, short releases instead of sweeping changes all at once, over the week. My primary focus is to stabilize the addon so that errors reports stop and the bag has basic (even if limited) functionality. This smaller, compartmentalized release schedule will make it easier to track down regressions as they arise, while allowing users to benefit from the addon much sooner. I'm going to keep this PR open for the time being, but expect another PR to "take over" this one. I'm going to push a new release in the next hour or two with some straight forward fixes, and we'll go from there. Thanks everyone! |
|
Hi @MleveK I am experiencing display freeze when opening bags. only for a second but it feels like my PC is getting stuck, annoying feeling. It happens every time, I open my bags which is often seeing I portal with the guild cloacks and am mount hunting with about 40 toons. I dont have an error lua seeing I disabled that so I am hoping you know what I am talking about and can help :) Maybe you have other people with similar experiences. Thank you in advance for looking into it. |
Is it still happening with all addons disabled except AdiBags? I'd guess it's another addon or an outdated AdiBags plugin. |
|
@cindynico You probably have some adibags plugin which freeze your game because they create a frame for each item in your bag. I had that too and I modified some of them to fix it. Look here: #782 (comment) |
|
@MleveK I updated from curse yd and I see my seperate reagent bag isnt there anymore, wasnt that in the recent update and does this mean i have to install the update from above again? |
|
@Frurox I'm working on it as we speak. Sorry for the delay everyone, my daughter got sick over the holiday weekend, and I was on dad duty. Trying to push a release with some fixes today. |
I sincerely only care that she is doing better, sick kids wreck our sleep and also crush our hearts. |
|
@Cidan Thank you for the update and hard work on this, Yes hope she is better RL 1st! |
|
Thanks folks, that means a lot! A new release is going out right now, .49, which contains most of the fixes in this patch. I've made a few small, minor changes around how things were implemented, favoring @jnwhiteh's abstraction. I'm going to leave this PR open through the next few days, then close it. If anything comes up, please open a new issue. Thanks! |
