Issues with account expiration dates

[Albvadi]

Adldap2 Version: 7.0.15
LDAP Type: Active Directory
PHP Version: 7.0.9

Description:

Hi, I have 4 types of users:

• User which does not expire
• User which not expired yet, but have and expiration date
• User expired
• User which does not expire, but with and expiration date set to 31/12/9999 (do not ask why.. 🤦‍♂️)

These are the values retrieved from AD:

In the last user, if I try to get the isExpired() status or the date with expirationDate(), I get the following exception:

[stevebauman]

Hi @Albvadi, looking into this now, thanks!

[stevebauman]

Hey @Albvadi, are you perhaps using the 32-bit version of PHP?

[Albvadi]

Yes, exactly: PHP 7.0.9 (cli) (built: Jul 20 2016 11:08:23) ( ZTS )
It´s a Xampp version, ApacheFriends XAMPP Version 7.0.9, and I think all xampp versions are 32-bit..

Is this the problem??

[stevebauman]

It's not a problem, it just may explain why my tests pass locally, and on travis, but the method fails in your environment:

https://github.com/Adldap2/Adldap2/blob/master/tests/Models/UserTest.php#L183-L194

I'm going to test on 32-bit and see if I reproduce this.

[Albvadi]

I´m using it in Laravel, but posted here because it´s a method not related with Laravel...

But, in the screenshot, the dump show the parameters and in the second, the value has a dot making a decimal value... maybe it´s a problem with Laravel and the requests??

[stevebauman]

It's not an issue of requests, it's definitely the 32-bit version of PHP:

http://php.net/manual/en/language.types.integer.php#language.types.integer.overflow

If PHP encounters a number beyond the bounds of the integer type, it will be interpreted as a float instead.

The expiry date value you have for the account converted to an integer exceeds the maximum integer size.

I'll see if I can patch this for 32-bit versions, thanks @Albvadi!

[Albvadi]

I'll see if I can patch this for 32-bit versions

That would be great!
Thanks!

[stevebauman]

Hi @Albvadi, I believe this was resolved with the following date() method here:

Adldap2/src/Models/User.php

Lines 1212 to 1214 in 85740a3

	$date = date($this->dateFormat, $unixTime);
	return new DateTime($date);

Can you verify by using the latest release?

[Albvadi]

I´ll try it as soon as possible.

[stevebauman]

Great, thanks @Albvadi! No rush, just want to make sure you're not experiencing this still.

[Albvadi]

Sorry, but the problem persist.
Really the code is the same.

$date = date($this->dateFormat, $unixTime); 
return new DateTime($date);

is the same than

return new DateTime(date($this->dateFormat, $unixTime));

The message error and the trace are the same than the original post.

[Albvadi]

ping @stevebauman

Hi,
a long time ago, I migrated to a 64bit PHP version and now, when I have taken up the modifications that involve using the expiration date, everything works as expected with the 64 bit version.

Perhaps, you want to close this issue because you do not support such old versions or because in LdapRecord you manage the dates differently and this does not happen. Its your choice.

I take this opportunity to thank you for the new projects you have in progress (LdapRecord, Scout (or Watchdog), etc ...).
You make life very easy for other mortals ... I hope I can use them soon .. 😉