Add sepa support #170
Merged
Add sepa support #170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexandrosMor
requested review from
Aleffio,
cyattilakiss,
maassenbas,
rikterbeek and
rkewlani
Closed
Aleffio
approved these changes
Apr 1, 2019
rkewlani
reviewed
Apr 3, 2019
| defaultPaymentMethodDetails.setSepaIbanNumber("DE87123456781234567890"); | ||
|
|
||
| PaymentsRequest paymentsRequest = createPaymentsCheckoutRequest(); | ||
| paymentsRequest.setApplicationInfo(null); |
There was a problem hiding this comment.
This is redundant. please remove null assignment.
There was a problem hiding this comment.
We need to remove the application info because the version is always updating and the mock request is not.
rkewlani
reviewed
Apr 3, 2019
| public void TestSepaPaymentMethodDetails() { | ||
| DefaultPaymentMethodDetails defaultPaymentMethodDetails=new DefaultPaymentMethodDetails(); | ||
| defaultPaymentMethodDetails.type(TYPE_SEPA_DIRECT_DEBIT); | ||
| defaultPaymentMethodDetails.setSepaOwnerName("A. Schneider"); |
There was a problem hiding this comment.
This type constant is not needed.
rkewlani
approved these changes
Apr 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.