[PW-828] Add application info to adyen-java-api-library #177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add default library name + version / private set
- Add default library fields test
- Add default application info on requests
- Fixed setters to avoid applicationInfo == null
- Add default library name + version / private set
- Request creation tests
- Fixed setters when value is null
martinsrenato
commented
Apr 10, 2019
martinsrenato
requested review from
Aleffio,
AlexandrosMor,
KadoBOT,
cyattilakiss,
maassenbas,
rikterbeek and
rkewlani
KadoBOT
reviewed
Apr 10, 2019
src/main/java/com/adyen/model/checkout/PaymentMethodsRequest.java
Outdated
Show resolved
Hide resolved
KadoBOT
approved these changes
Apr 10, 2019
cyattilakiss
approved these changes
Apr 12, 2019
- Change set method on tests for better coverage
src/main/java/com/adyen/model/checkout/PaymentSessionRequest.java
Outdated
Show resolved
Hide resolved
rkewlani
reviewed
Apr 12, 2019
rkewlani
reviewed
Apr 12, 2019
src/main/java/com/adyen/model/checkout/PaymentMethodsRequest.java
Outdated
Show resolved
Hide resolved
rkewlani
reviewed
Apr 12, 2019
- Reverted changes on requests that are not Payment or Modification - Removed setter from Payment and Modification requests
Aleffio
reviewed
Apr 12, 2019
- Fixed copyright
rikterbeek
approved these changes
Apr 15, 2019
AlexandrosMor
approved these changes
Apr 15, 2019
Aleffio
approved these changes
Apr 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ApplicationInfo sets library values on constructor and
setAdyenLibraryremoved.ApplicationInfo added to every request, with prefilled library name + version.
Added request tests.
Tested scenarios