Skip to content

added models, services and mocking test for binlookup apis #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 16, 2019
Merged

added models, services and mocking test for binlookup apis #191

merged 5 commits into from
May 16, 2019

Conversation

rikterbeek
Copy link
Contributor

@rikterbeek rikterbeek commented May 10, 2019 •
edited by martinsrenato
Loading

Description
Added BinLookup API /getCostEstimate and /get3dsAvailability

Tested scenarios
Success and fail cases with different request data

@rikterbeek rikterbeek requested a review from martinsrenato May 10, 2019 14:07
@coveralls
Copy link

coveralls commented May 13, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.1%) to 19.558% when pulling 4539fd2 on feature/PW-1252 into 3ace8aa on develop.

@martinsrenato martinsrenato changed the title [WIP] added models, services and mocking test for binlookup apis added models, services and mocking test for binlookup apis May 14, 2019
rkewlani
rkewlani reviewed May 14, 2019
View reviewed changes
@martinsrenato martinsrenato requested a review from rkewlani May 15, 2019 12:23
@martinsrenato martinsrenato merged commit 26917c8 into develop May 16, 2019
@martinsrenato martinsrenato deleted the feature/PW-1252 branch December 10, 2019 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexandrosMor AlexandrosMor Awaiting requested review from AlexandrosMor

@cyattilakiss cyattilakiss Awaiting requested review from cyattilakiss

@KadoBOT KadoBOT Awaiting requested review from KadoBOT

@maassenbas maassenbas Awaiting requested review from maassenbas

3 more reviewers

@Aleffio Aleffio Aleffio approved these changes

@martinsrenato martinsrenato martinsrenato approved these changes

@rkewlani rkewlani rkewlani approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rikterbeek @coveralls @Aleffio @martinsrenato @rkewlani