Small optimizations and cleanup #199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toString() may be accidentally called from logger and the secret password will be written to logs. This can be a big security problem so it's better to avoid using a password in toString() method
…ueOf(long value, int scale). Unit Test was also changed to use BigDecimal.equals() instead of compareTo() so the scale is also checked. 1000 cents was replaced with 1001 cent just to check that no any rounding problems
…new BigDecimal allocation
|
Hi @stokito, |
rkewlani
requested review from
Aleffio,
AlexandrosMor,
KadoBOT,
cyattilakiss,
martinsrenato and
rkewlani
|
Hi @rkewlani off course, I covered and checked that it's covered before changes. The coverage decreased just because it's less code now. |
rkewlani
approved these changes
May 23, 2019
martinsrenato
approved these changes
May 23, 2019
rikterbeek
approved these changes
May 23, 2019
rikterbeek
approved these changes
May 23, 2019
Aleffio
approved these changes
May 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigated and debugged the library I found some small performance issues.
Also I was lack of some documentation so I added it to JavaDoc