Added github templates for issues and PRs #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aleffio
approved these changes
Oct 20, 2017
rikterbeek
reviewed
Oct 20, 2017
.github/ISSUE_TEMPLATE.md
Outdated
| @@ -0,0 +1,10 @@ | |||
| | Q | A | |||
There was a problem hiding this comment.
Let's do Question and answers rather then Q and A.
.github/PULL_REQUEST_TEMPLATE.md
Outdated
| @@ -0,0 +1,5 @@ | |||
| | Q | A | |||
.github/PULL_REQUEST_TEMPLATE.md
Outdated
| | ---------------- | --- | ||
| | Request type | bugfix/feature | ||
| | Tested scenarios | Description of tested scenarios | ||
| | Fixed issues | #-prefixed issue number(s), if any |
There was a problem hiding this comment.
Maybe better to show these questions like this:
Description
<! Provide a description of the changes proposed in the pull request ->
Fixed Issues (if relevant)
- #<issue_number>: Issue title
- ...
Tested scenarios
- ...
- ...
There was a problem hiding this comment.
example see: magento/magento2#11576
lancergr
force-pushed
the
github-templates
branch
from
78150bb to
45999ff
Compare
maassenbas
approved these changes
Oct 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.