Changing name of Value to BarcodeValue in OutputBarcode corresponding to docs (and API) #1051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
michaelpaul
approved these changes
Nov 18, 2022
wboereboom
approved these changes
Nov 18, 2022
jillingk
added a commit
that referenced
this pull request
Jan 20, 2023
* Bump @typescript-eslint/eslint-plugin from 5.41.0 to 5.43.0 (#1039) Bumps [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) from 5.41.0 to 5.43.0. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v5.43.0/packages/eslint-plugin) --- updated-dependencies: - dependency-name: "@typescript-eslint/eslint-plugin" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add renovate.json (#1042) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update dependency @types/jest to v27.5.2 (#1043) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Arribatec/fix terminal comms typo (#1029) * Fix the namings of CommunicationOKFlag * Revert "Fix the namings of CommunicationOKFlag" This reverts commit 15e85c2. * Updated with correct linting * Update pOIStatus.ts Co-authored-by: jillingk <93914435+jillingk@users.noreply.github.com> Co-authored-by: Wouter Boereboom <62436079+wboereboom@users.noreply.github.com> * Update dependency eslint to v8.27.0 (#1047) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update dependency @typescript-eslint/parser to v5.43.0 (#1046) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Changed name of Value to BarcodeValue corresponding to docs(and API) (#1051) * Update actions/setup-node action to v3 (#1053) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Bump @typescript-eslint/parser from 5.43.0 to 5.45.0 (#1067) Bumps [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 5.43.0 to 5.45.0. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v5.45.0/packages/parser) --- updated-dependencies: - dependency-name: "@typescript-eslint/parser" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update actions/checkout action to v3 (#1052) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Wouter Boereboom <62436079+wboereboom@users.noreply.github.com> * add dataProtection service to library (#1063) * add dataProtection service to library * add missing import * fix mock class for unit test * fix: add balancePlatform to services index (#1068) * Delete dependabot.yml (#1059) * Update dependency eslint to v8.28.0 (#1057) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update dependency typescript to v4.9.3 (#1050) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update dependency ts-loader to v9 (#1055) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * update .npmignore (#1072) * Pw 7156/update readme (#1069) * update README * fix link to integration section * add webhooks to README.md * fix bullet lists in README * minor code example fix * process feedback * Update README.md Co-authored-by: Jeantwan Teuma <Morerice@users.noreply.github.com> * Update README.md Co-authored-by: Jeantwan Teuma <Morerice@users.noreply.github.com> * Grammar Co-authored-by: Jeantwan Teuma <Morerice@users.noreply.github.com> * Add banner to README (#1074) * Update dependency typescript to v4.9.4 (#1073) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * add basic auth option to the client (#1076) * remove API calls from unit tests. Remove ASCII headers from test files, use typings index in test classes. add missing entries to typings index class (#1075) * PW-7502: Bind QueryString type to URLSearchParams (#1077) * chore(deps): update dependency @types/node to v14.18.36 (#1044) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency nock to v13.3.0 (#1081) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * update unit tests to test uniform error handling over APIs (#1079) Co-authored-by: jillingk <93914435+jillingk@users.noreply.github.com> * Remove LGTM badges from README (#1080) * PW-7514: Fully Generated Management API client (#1064) * PW-7514: Update models * PW-7514: Switch to JAR based installation * PW-7514: Default API template * PW-7514: Customize API template * PW-7514: Serialize request * PW-7514: Query string * PW-7514: Fix version patch * PW-7514: Client generated * PW-7514: Export class by default * PW-7514: Make path and body params required * PW-7514: Dynamic service name * PW-7514: Link all classes into one parent * PW-7514: Dynamic method names * PW-7514: Fix merge issues * PW-7514: Generate using latest specs Co-authored-by: jillingk <93914435+jillingk@users.noreply.github.com> * [PW-7765] add create/disablePermit and simple UT (#1082) * add create/disablePermit and simple UT * Add serializer for Date objects and quick test Co-authored-by: Michael Paul <michael@michaelpaul.com.br> * Update package.json (#1084) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Eoin Falconer <eoin.falconer@hotmail.com> Co-authored-by: Wouter Boereboom <62436079+wboereboom@users.noreply.github.com> Co-authored-by: Jeantwan Teuma <Morerice@users.noreply.github.com> Co-authored-by: Michael Paul <michael@michaelpaul.com.br>
wboereboom
added a commit
that referenced
this pull request
Feb 13, 2023
* Bump @typescript-eslint/eslint-plugin from 5.41.0 to 5.43.0 (#1039) Bumps [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) from 5.41.0 to 5.43.0. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v5.43.0/packages/eslint-plugin) --- updated-dependencies: - dependency-name: "@typescript-eslint/eslint-plugin" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add renovate.json (#1042) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update dependency @types/jest to v27.5.2 (#1043) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Arribatec/fix terminal comms typo (#1029) * Fix the namings of CommunicationOKFlag * Revert "Fix the namings of CommunicationOKFlag" This reverts commit 15e85c2. * Updated with correct linting * Update pOIStatus.ts Co-authored-by: jillingk <93914435+jillingk@users.noreply.github.com> Co-authored-by: Wouter Boereboom <62436079+wboereboom@users.noreply.github.com> * Update dependency eslint to v8.27.0 (#1047) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update dependency @typescript-eslint/parser to v5.43.0 (#1046) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Changed name of Value to BarcodeValue corresponding to docs(and API) (#1051) * Update actions/setup-node action to v3 (#1053) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Bump @typescript-eslint/parser from 5.43.0 to 5.45.0 (#1067) Bumps [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 5.43.0 to 5.45.0. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v5.45.0/packages/parser) --- updated-dependencies: - dependency-name: "@typescript-eslint/parser" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update actions/checkout action to v3 (#1052) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Wouter Boereboom <62436079+wboereboom@users.noreply.github.com> * add dataProtection service to library (#1063) * add dataProtection service to library * add missing import * fix mock class for unit test * fix: add balancePlatform to services index (#1068) * Delete dependabot.yml (#1059) * Update dependency eslint to v8.28.0 (#1057) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update dependency typescript to v4.9.3 (#1050) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update dependency ts-loader to v9 (#1055) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * update .npmignore (#1072) * Pw 7156/update readme (#1069) * update README * fix link to integration section * add webhooks to README.md * fix bullet lists in README * minor code example fix * process feedback * Update README.md Co-authored-by: Jeantwan Teuma <Morerice@users.noreply.github.com> * Update README.md Co-authored-by: Jeantwan Teuma <Morerice@users.noreply.github.com> * Grammar Co-authored-by: Jeantwan Teuma <Morerice@users.noreply.github.com> * Add banner to README (#1074) * Update dependency typescript to v4.9.4 (#1073) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * add basic auth option to the client (#1076) * remove API calls from unit tests. Remove ASCII headers from test files, use typings index in test classes. add missing entries to typings index class (#1075) * PW-7502: Bind QueryString type to URLSearchParams (#1077) * chore(deps): update dependency @types/node to v14.18.36 (#1044) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency nock to v13.3.0 (#1081) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * update unit tests to test uniform error handling over APIs (#1079) Co-authored-by: jillingk <93914435+jillingk@users.noreply.github.com> * Remove LGTM badges from README (#1080) * PW-7514: Fully Generated Management API client (#1064) * PW-7514: Update models * PW-7514: Switch to JAR based installation * PW-7514: Default API template * PW-7514: Customize API template * PW-7514: Serialize request * PW-7514: Query string * PW-7514: Fix version patch * PW-7514: Client generated * PW-7514: Export class by default * PW-7514: Make path and body params required * PW-7514: Dynamic service name * PW-7514: Link all classes into one parent * PW-7514: Dynamic method names * PW-7514: Fix merge issues * PW-7514: Generate using latest specs Co-authored-by: jillingk <93914435+jillingk@users.noreply.github.com> * [PW-7765] add create/disablePermit and simple UT (#1082) * add create/disablePermit and simple UT * Add serializer for Date objects and quick test Co-authored-by: Michael Paul <michael@michaelpaul.com.br> * Update package.json (#1084) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Eoin Falconer <eoin.falconer@hotmail.com> Co-authored-by: Wouter Boereboom <62436079+wboereboom@users.noreply.github.com> Co-authored-by: Jeantwan Teuma <Morerice@users.noreply.github.com> Co-authored-by: Michael Paul <michael@michaelpaul.com.br>
wboereboom
added a commit
that referenced
this pull request
Feb 13, 2023
* Bump @typescript-eslint/eslint-plugin from 5.41.0 to 5.43.0 (#1039) Bumps [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) from 5.41.0 to 5.43.0. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v5.43.0/packages/eslint-plugin) --- updated-dependencies: - dependency-name: "@typescript-eslint/eslint-plugin" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add renovate.json (#1042) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update dependency @types/jest to v27.5.2 (#1043) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Arribatec/fix terminal comms typo (#1029) * Fix the namings of CommunicationOKFlag * Revert "Fix the namings of CommunicationOKFlag" This reverts commit 15e85c2. * Updated with correct linting * Update pOIStatus.ts Co-authored-by: jillingk <93914435+jillingk@users.noreply.github.com> Co-authored-by: Wouter Boereboom <62436079+wboereboom@users.noreply.github.com> * Update dependency eslint to v8.27.0 (#1047) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update dependency @typescript-eslint/parser to v5.43.0 (#1046) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Changed name of Value to BarcodeValue corresponding to docs(and API) (#1051) * Update actions/setup-node action to v3 (#1053) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Bump @typescript-eslint/parser from 5.43.0 to 5.45.0 (#1067) Bumps [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 5.43.0 to 5.45.0. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v5.45.0/packages/parser) --- updated-dependencies: - dependency-name: "@typescript-eslint/parser" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update actions/checkout action to v3 (#1052) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Wouter Boereboom <62436079+wboereboom@users.noreply.github.com> * add dataProtection service to library (#1063) * add dataProtection service to library * add missing import * fix mock class for unit test * fix: add balancePlatform to services index (#1068) * Delete dependabot.yml (#1059) * Update dependency eslint to v8.28.0 (#1057) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update dependency typescript to v4.9.3 (#1050) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update dependency ts-loader to v9 (#1055) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * update .npmignore (#1072) * Pw 7156/update readme (#1069) * update README * fix link to integration section * add webhooks to README.md * fix bullet lists in README * minor code example fix * process feedback * Update README.md Co-authored-by: Jeantwan Teuma <Morerice@users.noreply.github.com> * Update README.md Co-authored-by: Jeantwan Teuma <Morerice@users.noreply.github.com> * Grammar Co-authored-by: Jeantwan Teuma <Morerice@users.noreply.github.com> * Add banner to README (#1074) * Update dependency typescript to v4.9.4 (#1073) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * add basic auth option to the client (#1076) * remove API calls from unit tests. Remove ASCII headers from test files, use typings index in test classes. add missing entries to typings index class (#1075) * PW-7502: Bind QueryString type to URLSearchParams (#1077) * chore(deps): update dependency @types/node to v14.18.36 (#1044) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency nock to v13.3.0 (#1081) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * update unit tests to test uniform error handling over APIs (#1079) Co-authored-by: jillingk <93914435+jillingk@users.noreply.github.com> * Remove LGTM badges from README (#1080) * PW-7514: Fully Generated Management API client (#1064) * PW-7514: Update models * PW-7514: Switch to JAR based installation * PW-7514: Default API template * PW-7514: Customize API template * PW-7514: Serialize request * PW-7514: Query string * PW-7514: Fix version patch * PW-7514: Client generated * PW-7514: Export class by default * PW-7514: Make path and body params required * PW-7514: Dynamic service name * PW-7514: Link all classes into one parent * PW-7514: Dynamic method names * PW-7514: Fix merge issues * PW-7514: Generate using latest specs Co-authored-by: jillingk <93914435+jillingk@users.noreply.github.com> * [PW-7765] add create/disablePermit and simple UT (#1082) * add create/disablePermit and simple UT * Add serializer for Date objects and quick test Co-authored-by: Michael Paul <michael@michaelpaul.com.br> * Update package.json (#1084) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Eoin Falconer <eoin.falconer@hotmail.com> Co-authored-by: Wouter Boereboom <62436079+wboereboom@users.noreply.github.com> Co-authored-by: Jeantwan Teuma <Morerice@users.noreply.github.com> Co-authored-by: Michael Paul <michael@michaelpaul.com.br>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#1048 mentioned that populating the field for a print-request yield an error saying the
Valueis not a correct field. Indeed instead it should have beenBarcodeValue, so I changed it accordingly.Tested scenarios
Tested it on a POS machine and indeed I got the same error. When adjusting the name field to the correct one I was able to successfully print a receipt.
Fixed issue: #1048