-
Notifications
You must be signed in to change notification settings - Fork 113
Remove leading backslash #797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @gcatanese, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses a minor syntax correction in a template file by removing an extraneous leading backslash from a use
statement. This change ensures that the generated code adheres to standard PHP namespace import practices, improving code consistency and readability.
Highlights
- Template Syntax Fix: Removed an unnecessary leading backslash from the
use
statement forArrayAccess
within thetemplates/model.mustache
file, changinguse \ArrayAccess;
touse ArrayAccess;
.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly removes a redundant leading backslash from the use ArrayAccess;
statement, improving code style. My review includes a comment to also update the PHPDoc for ArrayAccess
in the same file for consistency.
Additionally, to fully achieve the PR's goal of fixing templates, I'd recommend extending this change to other templates. The model_generic.mustache
template contains several references to global classes with a leading backslash (e.g., \JsonSerializable
, \InvalidArgumentException
, \DateTime
). The best practice would be to add use
statements for them in model.mustache
and then use the class names without the backslash in model_generic.mustache
. This would make the generated code more consistent and readable.
63dac79
to
986a565
Compare
|
Fix templates to remove leading backslash
to