Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Introduce script setup #121

Merged
merged 5 commits into from
Jan 16, 2023
Merged

✨ Introduce script setup #121

merged 5 commits into from
Jan 16, 2023

Conversation

vivy27
Copy link
Contributor

@vivy27 vivy27 commented Jan 2, 2023 •
edited
Loading

Relates to #

📝 Description

Add a brief description

💥 Is this a breaking change (Yes/No):

  • No
  • Yes (please describe the impact and migration path for existing Lume users)

📝 Additional Information

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@netlify
Copy link

netlify bot commented Jan 2, 2023 •
edited
Loading

✅ Deploy Preview for adyen-lume ready!

Name Link
🔨 Latest commit 82171bc
🔍 Latest deploy log https://app.netlify.com/sites/adyen-lume/deploys/63bfd8f5c414b90009662537
😎 Deploy Preview https://deploy-preview-121--adyen-lume.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@vivy27
Copy link
Contributor Author

vivy27 commented Jan 2, 2023

  • Created this new MR for script setup
  • Addressed all the unit test failures

@vivy27 vivy27 changed the title Introduce script setup ✨ Introduce script setup Jan 2, 2023
@vivy27 vivy27 mentioned this pull request Jan 2, 2023
Closed
@vivy27 vivy27 marked this pull request as ready for review January 6, 2023 09:05
@vivy27 vivy27 requested a review from a team as a code owner January 6, 2023 09:05
joao-m-santos
joao-m-santos previously approved these changes Jan 10, 2023
View reviewed changes
@joao-m-santos
Copy link
Contributor

Fixed conflicts; @govind-srinidhi or @Lucas1981 can you review this one, since me and Vivian worked on it?

@joao-m-santos joao-m-santos requested a review from a team January 16, 2023 09:29
@joao-m-santos joao-m-santos merged commit 352b8b1 into main Jan 16, 2023
@joao-m-santos joao-m-santos mentioned this pull request Jan 18, 2023
Merged
@joao-m-santos joao-m-santos deleted the introduce-script-setup branch February 1, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@govind-srinidhi govind-srinidhi govind-srinidhi approved these changes

@Lucas1981 Lucas1981 Awaiting requested review from Lucas1981

@joao-m-santos joao-m-santos Awaiting requested review from joao-m-santos

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vivy27 @joao-m-santos @govind-srinidhi @Lucas1981