-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ introduce script setup #4
Conversation
@vivy27 could we replace |
We could write our own flush, however, it's a dev dep, so doesn't add up to our bundle. |
True, but looking at this package src code makes me feel like we could just add it ourselves and not rely on an external package. In general, keeping the dependency list as small as possible is a good practice, since it's less prone to issues (security, package deletion, etc.) |
Yeah, That absolutely makes sense. I can add the function to flush promises. |
145250e
to
b367b3c
Compare
93adb5f
to
0c4b0f6
Compare
0c4b0f6
to
2ad8710
Compare
2ad8710
to
1fed2b0
Compare
1fed2b0
to
1cd0d51
Compare
✅ Deploy Preview for adyen-lume ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
1cd0d51
to
9485021
Compare
9485021
to
5e27bb3
Compare
Closing this MR as this branch is quite outdated. Therefore, created a new MR #121 |
WIP: A few npm packages need to be updated.