Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝 Added figma links to the chart stories #53

Merged
merged 2 commits into from
Nov 3, 2022

Conversation

govind-srinidhi
Copy link
Contributor

Relates to #

📝 Description

Added figma links to the chart stories

💥 Is this a breaking change (Yes/No):

  • No
  • Yes (please describe the impact and migration path for existing Lume users)

📝 Additional Information

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@govind-srinidhi govind-srinidhi requested a review from a team as a code owner November 3, 2022 09:55
@joao-m-santos
Copy link
Contributor

Shouldn't use UI files emoji, for Storybook & other documentation commits it should be 📝 !

@govind-srinidhi govind-srinidhi changed the title 💄 Added figma links to the chart stories 📝 Added figma links to the chart stories Nov 3, 2022
@govind-srinidhi govind-srinidhi merged commit a499f90 into main Nov 3, 2022
@joao-m-santos joao-m-santos deleted the link-figma-pages-storybook branch February 1, 2023 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants