Fix skim cost calculation on compact graph #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When skimming the network using the compact graph the last link (within the dataframe) was being ignored. Co-authored-by: chrisobi02 <chrisgobrien02@gmail.com>
pedrocamargo
approved these changes
Nov 29, 2022
pedrocamargo
added a commit
that referenced
this pull request
Nov 29, 2022
* Upgrades Numpy version (#353) * Limits pyarrow version * Makes PyArrow an optional dependency (#356) Co-authored-by: pveigadecamargo <pveigadecamargo@anl.gov> * Update setup.py (#357) * Bumps up version * Updates setup * Sets version for AequilibraE * Fixes packaging (#362) Co-authored-by: pveigadecamargo <pveigadecamargo@anl.gov> Co-authored-by: djfrancesco <pacullfrancois@gmail.com> * Fix: #365 Use specified number of cores (#366) * Fix skim cost calculation on compact graph (#367) When skimming the network using the compact graph the last link (within the dataframe) was being ignored. Co-authored-by: chrisobi02 <chrisgobrien02@gmail.com> Co-authored-by: Jamie Cook <jamie.cook@veitchlister.com.au> Co-authored-by: djfrancesco <pacullfrancois@gmail.com> Co-authored-by: Jake Moss <jake.moss@uqconnect.edu.au>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When skimming the network using the compact graph the last link (within the dataframe) was being ignored.
Co-authored-by: chrisobi02 chrisgobrien02@gmail.com